diff options
author | Joffrey F <joffrey@docker.com> | 2018-01-31 15:26:09 -0800 |
---|---|---|
committer | Joffrey F <joffrey@docker.com> | 2018-01-31 15:26:09 -0800 |
commit | bf2ea4dcb01ffa3329fef91570fe3bd40fad4d7d (patch) | |
tree | 806cd6a76ca91a4128332f8c91f205c7d07ddd8b | |
parent | 82e57a4c158c4ff13340a29319c6445d81ddc208 (diff) | |
download | docker-py-bf2ea4dcb01ffa3329fef91570fe3bd40fad4d7d.tar.gz |
Rename `name` parameter in `pull` method to `repository`1441-pull-repository-name
for consistency with APIClient naming
Signed-off-by: Joffrey F <joffrey@docker.com>
-rw-r--r-- | docker/models/images.py | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/docker/models/images.py b/docker/models/images.py index 97c5503..0f3c71a 100644 --- a/docker/models/images.py +++ b/docker/models/images.py @@ -266,7 +266,7 @@ class ImageCollection(Collection): return [self.get(i) for i in images] - def pull(self, name, tag=None, **kwargs): + def pull(self, repository, tag=None, **kwargs): """ Pull an image of the given name and return it. Similar to the ``docker pull`` command. @@ -280,7 +280,6 @@ class ImageCollection(Collection): Args: name (str): The repository to pull tag (str): The tag to pull - insecure_registry (bool): Use an insecure registry auth_config (dict): Override the credentials that :py:meth:`~docker.client.DockerClient.login` has set for this request. ``auth_config`` should contain the ``username`` @@ -305,12 +304,12 @@ class ImageCollection(Collection): >>> images = client.images.pull('busybox') """ if not tag: - name, tag = parse_repository_tag(name) + repository, tag = parse_repository_tag(repository) - self.client.api.pull(name, tag=tag, **kwargs) + self.client.api.pull(repository, tag=tag, **kwargs) if tag: - return self.get('{0}:{1}'.format(name, tag)) - return self.list(name) + return self.get('{0}:{1}'.format(repository, tag)) + return self.list(repository) def push(self, repository, tag=None, **kwargs): return self.client.api.push(repository, tag=tag, **kwargs) |