summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoffrey F <joffrey@docker.com>2015-06-24 22:58:56 +0200
committerJoffrey F <joffrey@docker.com>2015-06-24 22:58:56 +0200
commit30fac5b8799a50fbe837a674de15408c001f3f0e (patch)
tree89694b0f24797220bb4717cd6ba504bc602464d5
parent772262fed0020621f5c589eb4a8688caf59af0db (diff)
downloaddocker-py-30fac5b8799a50fbe837a674de15408c001f3f0e.tar.gz
Fix stop timeout bugfix_649
-rw-r--r--docker/client.py2
-rw-r--r--tests/integration_test.py5
2 files changed, 6 insertions, 1 deletions
diff --git a/docker/client.py b/docker/client.py
index f63da50..8bcc419 100644
--- a/docker/client.py
+++ b/docker/client.py
@@ -1101,7 +1101,7 @@ class Client(requests.Session):
url = self._url("/containers/{0}/stop".format(container))
res = self._post(url, params=params,
- timeout=(timeout + self.timeout))
+ timeout=(timeout + (self.timeout or 0)))
self._raise_for_status(res)
@check_resource
diff --git a/tests/integration_test.py b/tests/integration_test.py
index c9ab140..4b9869e 100644
--- a/tests/integration_test.py
+++ b/tests/integration_test.py
@@ -1467,6 +1467,11 @@ class TestRegressions(BaseTestCase):
result = self.client.containers(all=True, trunc=True)
self.assertEqual(len(result[0]['Id']), 12)
+ def test_649(self):
+ self.client.timeout = None
+ ctnr = self.client.create_container('busybox', ['sleep', '2'])
+ self.client.start(ctnr)
+ self.client.stop(ctnr)
if __name__ == '__main__':
c = docker.Client(base_url=DEFAULT_BASE_URL)