<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/docker.git/pkg/plugins/client_test.go, branch master</title>
<subtitle>github.com: dotcloud/docker.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/'/>
<entry>
<title>Reduce TestClientWithRequestTimeout flakiness</title>
<updated>2021-06-29T21:53:23+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2021-06-29T21:53:23+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=00a4f67ddf78883bb6e891ec3943de08564e209d'/>
<id>00a4f67ddf78883bb6e891ec3943de08564e209d</id>
<content type='text'>
The test sometimes failed because no error was returned:

    === Failed
    === FAIL: pkg/plugins TestClientWithRequestTimeout (0.00s)
         client_test.go:254: assertion failed: expected an error, got nil: expected error

Possibly caused by a race condition, as the sleep was just 1 ms longer than the timeout;
this patch is increasing the sleep in the response to try to reduce flakiness.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The test sometimes failed because no error was returned:

    === Failed
    === FAIL: pkg/plugins TestClientWithRequestTimeout (0.00s)
         client_test.go:254: assertion failed: expected an error, got nil: expected error

Possibly caused by a race condition, as the sleep was just 1 ms longer than the timeout;
this patch is increasing the sleep in the response to try to reduce flakiness.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace errors.Cause() with errors.Is() / errors.As()</title>
<updated>2020-04-28T22:28:41+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2020-04-17T10:01:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=07d60bc2571ba3d680f21adc84d87803ab4959c6'/>
<id>07d60bc2571ba3d680f21adc84d87803ab4959c6</id>
<content type='text'>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>bump gotest.tools v3.0.1 for compatibility with Go 1.14</title>
<updated>2020-02-10T23:06:42+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2020-02-07T13:39:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=9f0b3f5609faf69537cdf1882c251deec6e9eb26'/>
<id>9f0b3f5609faf69537cdf1882c251deec6e9eb26</id>
<content type='text'>
full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.1

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.1

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pkg/plugins: use constants for http methods</title>
<updated>2019-10-13T17:11:30+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2019-10-12T18:44:07+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=aa655a4d73693741cd3f8bc44566eb34585b3303'/>
<id>aa655a4d73693741cd3f8bc44566eb34585b3303</id>
<content type='text'>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Harden TestClientWithRequestTimeout</title>
<updated>2019-07-12T10:31:51+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2019-04-18T09:59:25+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=c7816c532374ad9461b78b2166922bcd21a3405f'/>
<id>c7816c532374ad9461b78b2166922bcd21a3405f</id>
<content type='text'>
DeadlineExceeded now implements a TimeOut() function,
since https://github.com/golang/go/commit/dc4427f3727804ded270bc6a7a8066ccb3c151d0

Check for this interface, to prevent possibly incorrect failures;

```
00:16:41 --- FAIL: TestClientWithRequestTimeout (0.00s)
00:16:41     client_test.go:259: assertion failed:
00:16:41         --- context.DeadlineExceeded
00:16:41         +++ err
00:16:41         :
00:16:41         	-: context.deadlineExceededError{}
00:16:41         	+: &amp;net.OpError{Op: "dial", Net: "tcp", Addr: s"127.0.0.1:49294", Err: &amp;poll.TimeoutError{}}
00:16:41
```

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
DeadlineExceeded now implements a TimeOut() function,
since https://github.com/golang/go/commit/dc4427f3727804ded270bc6a7a8066ccb3c151d0

Check for this interface, to prevent possibly incorrect failures;

```
00:16:41 --- FAIL: TestClientWithRequestTimeout (0.00s)
00:16:41     client_test.go:259: assertion failed:
00:16:41         --- context.DeadlineExceeded
00:16:41         +++ err
00:16:41         :
00:16:41         	-: context.deadlineExceededError{}
00:16:41         	+: &amp;net.OpError{Op: "dial", Net: "tcp", Addr: s"127.0.0.1:49294", Err: &amp;poll.TimeoutError{}}
00:16:41
```

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Update tests to use gotest.tools 👼</title>
<updated>2018-06-13T07:04:30+00:00</updated>
<author>
<name>Vincent Demeester</name>
<email>vincent@sbr.pm</email>
</author>
<published>2018-06-11T13:32:11+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=38457285242e57306c5b7ee652c7ccbb9fbd6713'/>
<id>38457285242e57306c5b7ee652c7ccbb9fbd6713</id>
<content type='text'>
Signed-off-by: Vincent Demeester &lt;vincent@sbr.pm&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Vincent Demeester &lt;vincent@sbr.pm&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Automated migration using</title>
<updated>2018-03-16T15:03:43+00:00</updated>
<author>
<name>Daniel Nephin</name>
<email>dnephin@docker.com</email>
</author>
<published>2018-03-13T19:28:34+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=6be0f709830113966f295401327b027ec2f0bbca'/>
<id>6be0f709830113966f295401327b027ec2f0bbca</id>
<content type='text'>
gty-migrate-from-testify --ignore-build-tags

Signed-off-by: Daniel Nephin &lt;dnephin@docker.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
gty-migrate-from-testify --ignore-build-tags

Signed-off-by: Daniel Nephin &lt;dnephin@docker.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds a unit test for plugin request timeout</title>
<updated>2018-03-05T20:38:56+00:00</updated>
<author>
<name>Brian Goff</name>
<email>cpuguy83@gmail.com</email>
</author>
<published>2018-03-05T20:29:02+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=7ca971fb495e4de4aa4455964625974464d86920'/>
<id>7ca971fb495e4de4aa4455964625974464d86920</id>
<content type='text'>
Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add canonical import comment</title>
<updated>2018-02-05T21:51:57+00:00</updated>
<author>
<name>Daniel Nephin</name>
<email>dnephin@docker.com</email>
</author>
<published>2018-02-05T21:05:59+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=4f0d95fa6ee7f865597c03b9e63702cdcb0f7067'/>
<id>4f0d95fa6ee7f865597c03b9e63702cdcb0f7067</id>
<content type='text'>
Signed-off-by: Daniel Nephin &lt;dnephin@docker.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Daniel Nephin &lt;dnephin@docker.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Increase the Coverage of pkg/plugins</title>
<updated>2017-06-12T07:23:10+00:00</updated>
<author>
<name>Raja Sami</name>
<email>raja.sami@tenpearls.com</email>
</author>
<published>2017-05-22T09:38:23+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/docker.git/commit/?id=8dd100a2297a34a0aef422383117fb0c3314fba1'/>
<id>8dd100a2297a34a0aef422383117fb0c3314fba1</id>
<content type='text'>
Increases the test coverage of pkg/plugins.
Changed signature of function NewClientWithTimeout in pkg/plugin/client, to
take time.Duration instead of integers.

Signed-off-by: Raja Sami &lt;raja.sami@tenpearl.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Increases the test coverage of pkg/plugins.
Changed signature of function NewClientWithTimeout in pkg/plugin/client, to
take time.Duration instead of integers.

Signed-off-by: Raja Sami &lt;raja.sami@tenpearl.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
