diff options
| author | Sebastiaan van Stijn <github@gone.nl> | 2020-06-08 17:16:01 +0200 |
|---|---|---|
| committer | Sebastiaan van Stijn <github@gone.nl> | 2020-06-08 17:16:44 +0200 |
| commit | d378625554dc5d568d754b635c1d0fb8dae3c4bf (patch) | |
| tree | a317104239549138e9dbd68fc1630efd38b593f2 | |
| parent | 2dd013458988ce30eba34c57c088e2438b372aa4 (diff) | |
| download | docker-d378625554dc5d568d754b635c1d0fb8dae3c4bf.tar.gz | |
info: add warnings about missing blkio cgroup support
These warnings were only logged, and could therefore be overlooked
by users. This patch makes these more visible by returning them as
warnings in the API response.
We should probably consider adding "boolean" (?) fields for these
as well, so that they can be consumed in other ways. In addition,
some of these warnings could potentially be grouped to reduce the
number of warnings that are printed.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| -rw-r--r-- | daemon/info_unix.go | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/daemon/info_unix.go b/daemon/info_unix.go index b9d54101b0..ab9f508058 100644 --- a/daemon/info_unix.go +++ b/daemon/info_unix.go @@ -124,6 +124,25 @@ func (daemon *Daemon) fillPlatformInfo(v *types.Info, sysInfo *sysinfo.SysInfo) if v.CgroupVersion == "2" { v.Warnings = append(v.Warnings, "WARNING: Support for cgroup v2 is experimental") } + // TODO add fields for these options in types.Info + if !sysInfo.BlkioWeight { + v.Warnings = append(v.Warnings, "WARNING: No blkio weight support") + } + if !sysInfo.BlkioWeightDevice { + v.Warnings = append(v.Warnings, "WARNING: No blkio weight_device support") + } + if !sysInfo.BlkioReadBpsDevice { + v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.read_bps_device support") + } + if !sysInfo.BlkioWriteBpsDevice { + v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.write_bps_device support") + } + if !sysInfo.BlkioReadIOpsDevice { + v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.read_iops_device support") + } + if !sysInfo.BlkioWriteIOpsDevice { + v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.write_iops_device support") + } } if !v.IPv4Forwarding { v.Warnings = append(v.Warnings, "WARNING: IPv4 forwarding is disabled") |