summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Johnston <matt@ucc.asn.au>2007-02-12 10:44:47 +0000
committerMatt Johnston <matt@ucc.asn.au>2007-02-12 10:44:47 +0000
commite1d814eb5be13dfbc859376110433e0712388994 (patch)
tree9adf0343cfcfb2111ef99563da5e34adbf3484fc
parentd1dd099c8af6f5a456be34bad3aa72e92b9fa4cf (diff)
downloaddropbear-e1d814eb5be13dfbc859376110433e0712388994.tar.gz
Don't erase every buffer, it's too time consuming.
On systems where it matters encrypted swap should be enabled anyway.
-rw-r--r--packet.c4
-rw-r--r--process-packet.c1
2 files changed, 0 insertions, 5 deletions
diff --git a/packet.c b/packet.c
index b2c6174..9e7c67a 100644
--- a/packet.c
+++ b/packet.c
@@ -446,10 +446,6 @@ void encrypt_packet() {
}
/* finished with payload */
- buf_burn(ses.writepayload); /* XXX This is probably a good idea, and isn't
- _that_ likely to hurt performance too badly.
- Buffers can have cleartext passwords etc, or
- other sensitive data */
buf_setpos(ses.writepayload, 0);
buf_setlen(ses.writepayload, 0);
diff --git a/process-packet.c b/process-packet.c
index 07fc130..ba39d9f 100644
--- a/process-packet.c
+++ b/process-packet.c
@@ -119,7 +119,6 @@ void process_packet() {
recv_unimplemented();
out:
- buf_burn(ses.payload); /* Clear the memory to avoid swapping it out */
buf_free(ses.payload);
ses.payload = NULL;