From 859f547aa1c2212fe90d31832d65c4223943172b Mon Sep 17 00:00:00 2001 From: Matt Johnston Date: Sun, 4 Jan 2015 22:22:43 +0800 Subject: Open directories O_RDONLY for fsync, add debugging if it fails --- svr-kex.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'svr-kex.c') diff --git a/svr-kex.c b/svr-kex.c index 01c76e6..6cc5433 100644 --- a/svr-kex.c +++ b/svr-kex.c @@ -91,12 +91,15 @@ static void fsync_parent_dir(const char* fn) { #ifdef HAVE_LIBGEN_H char *fn_dir = m_strdup(fn); char *dir = dirname(fn_dir); - /* some OSes need the fd to be writable for fsync */ - int dirfd = open(dir, O_RDWR); + int dirfd = open(dir, O_RDONLY); if (dirfd != -1) { - fsync(dirfd); + if (fsync(dirfd) != 0) { + TRACE(("fsync of directory %s failed: %s", dir, strerror(errno))) + } m_close(dirfd); + } else { + TRACE(("error opening directory %s for fsync: %s", dir, strerror(errno))) } free(fn_dir); -- cgit v1.2.1