summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosé Valim <jose.valim@dashbit.co>2020-02-09 09:44:46 +0100
committerJosé Valim <jose.valim@dashbit.co>2020-02-09 09:44:46 +0100
commit4abd1128fe4b720fcac466f0ac84f7a38ee1c49d (patch)
tree871a0d118f4be2a36c4b10c6b7a56301bffbe0ba
parent1fa3c45d1b778a24c814b97a49581af977fd61c8 (diff)
downloadelixir-4abd1128fe4b720fcac466f0ac84f7a38ee1c49d.tar.gz
Update TODO notes
-rw-r--r--lib/logger/lib/logger.ex2
-rw-r--r--lib/logger/lib/logger/handler.ex6
2 files changed, 5 insertions, 3 deletions
diff --git a/lib/logger/lib/logger.ex b/lib/logger/lib/logger.ex
index b3ce0c447..1e12fbad1 100644
--- a/lib/logger/lib/logger.ex
+++ b/lib/logger/lib/logger.ex
@@ -843,7 +843,7 @@ defmodule Logger do
:logger.macro_log(%{}, level, chardata, add_elixir_domain(metadata))
end
- # TODO: Remove that in Elixir 2.0
+ # TODO: Remove this on Elixir v2.0
def __do_log__(level, other, metadata) do
IO.warn("passing #{inspect(other)} to Logger is deprecated, expected a binary or an iolist")
:logger.macro_log(%{}, level, to_string(other), add_elixir_domain(metadata))
diff --git a/lib/logger/lib/logger/handler.ex b/lib/logger/lib/logger/handler.ex
index f522021fc..02554ace0 100644
--- a/lib/logger/lib/logger/handler.ex
+++ b/lib/logger/lib/logger/handler.ex
@@ -6,7 +6,7 @@ defmodule Logger.Handler do
## Conversions
- # TODO: Remove this mapping once we support all of Erlang types (2.0)
+ # TODO: Remove this mapping once we remove old Logger Backends (v2.0)
defp erlang_level_to_elixir_level(:none), do: :error
defp erlang_level_to_elixir_level(:emergency), do: :error
defp erlang_level_to_elixir_level(:alert), do: :error
@@ -28,7 +28,7 @@ defmodule Logger.Handler do
{:ok, update_in(config.config, &Map.merge(default_config(), &1))}
end
- # TODO: Remove when we will support OTP 22+
+ # TODO: Remove this once we support Erlang/OTP 22+ exclusively.
def changing_config(current, new), do: changing_config(:set, current, new)
def changing_config(
@@ -175,6 +175,8 @@ defmodule Logger.Handler do
# TODO: We should only do this for legacy handlers.
# The new handlers should accept all metadata as is
# and receive the system time unit rather than tuples.
+ # The new handlers should also receive structured
+ # logging events as is.
defp erlang_metadata_to_elixir_metadata(metadata) do
metadata =
case metadata do