1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
|
Code.require_file("../test_helper.exs", __DIR__)
defmodule Kernel.GuardTest do
use ExUnit.Case, async: true
describe "Kernel.defguard(p) usage" do
defmodule GuardsInMacros do
defguard is_foo(atom) when atom == :foo
defmacro is_compile_time_foo(atom) when is_foo(atom) do
quote do: unquote(__MODULE__).is_foo(unquote(atom))
end
end
test "guards can be used in other macros in the same module" do
require GuardsInMacros
assert GuardsInMacros.is_foo(:foo)
refute GuardsInMacros.is_foo(:baz)
assert GuardsInMacros.is_compile_time_foo(:foo)
end
defmodule GuardsInFuns do
defguard is_foo(atom) when atom == :foo
defguard is_equal(foo, bar) when foo == bar
def is_foobar(atom) when is_foo(atom) do
is_foo(atom)
end
end
test "guards can be used in other funs in the same module" do
require GuardsInFuns
assert GuardsInFuns.is_foo(:foo)
refute GuardsInFuns.is_foo(:bar)
end
test "guards do not change code evaluation semantics" do
require GuardsInFuns
x = 1
assert GuardsInFuns.is_equal(x = 2, x) == false
assert x == 2
end
defmodule MacrosInGuards do
defmacro is_foo(atom) do
quote do
unquote(atom) == :foo
end
end
defguard is_foobar(atom) when is_foo(atom) or atom == :bar
end
test "macros can be used in other guards in the same module" do
require MacrosInGuards
assert MacrosInGuards.is_foobar(:foo)
assert MacrosInGuards.is_foobar(:bar)
refute MacrosInGuards.is_foobar(:baz)
end
defmodule GuardsInGuards do
defguard is_foo(atom) when atom == :foo
defguard is_foobar(atom) when is_foo(atom) or atom == :bar
end
test "guards can be used in other guards in the same module" do
require GuardsInGuards
assert GuardsInGuards.is_foobar(:foo)
assert GuardsInGuards.is_foobar(:bar)
refute GuardsInGuards.is_foobar(:baz)
end
defmodule DefaultArgs do
defguard is_divisible(value, remainder \\ 2)
when is_integer(value) and rem(value, remainder) == 0
end
test "permits default values in args" do
require DefaultArgs
assert DefaultArgs.is_divisible(2)
refute DefaultArgs.is_divisible(1)
assert DefaultArgs.is_divisible(3, 3)
refute DefaultArgs.is_divisible(3, 4)
end
test "doesn't allow matching in args" do
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule Integer.Args do
defguard foo(value, 1) when is_integer(value)
end
end
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule String.Args do
defguard foo(value, "string") when is_integer(value)
end
end
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule Atom.Args do
defguard foo(value, :atom) when is_integer(value)
end
end
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule Tuple.Args do
defguard foo(value, {foo, bar}) when is_integer(value)
end
end
end
defmodule IntegerPrivateGuards do
defguardp is_even(value) when is_integer(value) and rem(value, 2) == 0
def is_even_and_large?(value) when is_even(value) and value > 100, do: true
def is_even_and_large?(_), do: false
def is_even_and_small?(value) do
if is_even(value) and value <= 100, do: true, else: false
end
end
test "defguardp defines private guards that work inside and outside guard clauses" do
assert IntegerPrivateGuards.is_even_and_large?(102)
refute IntegerPrivateGuards.is_even_and_large?(98)
refute IntegerPrivateGuards.is_even_and_large?(99)
refute IntegerPrivateGuards.is_even_and_large?(103)
assert IntegerPrivateGuards.is_even_and_small?(98)
refute IntegerPrivateGuards.is_even_and_small?(99)
refute IntegerPrivateGuards.is_even_and_small?(102)
refute IntegerPrivateGuards.is_even_and_small?(103)
assert_raise CompileError, ~r"cannot invoke local is_even/1 inside guard", fn ->
defmodule IntegerPrivateGuardUtils do
import IntegerPrivateGuards
def is_even_and_large?(value) when is_even(value) and value > 100, do: true
def is_even_and_large?(_), do: false
end
end
assert_raise CompileError, ~r"undefined function is_even/1", fn ->
defmodule IntegerPrivateFunctionUtils do
import IntegerPrivateGuards
def is_even_and_small?(value) do
if is_even(value) and value <= 100, do: true, else: false
end
end
end
end
test "requires a proper macro name" do
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule(LiteralUsage, do: defguard("literal is bad"))
end
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule(RemoteUsage, do: defguard(Remote.call(is_bad)))
end
end
test "handles overriding appropriately" do
assert_raise CompileError, ~r"defmacro (.*?) already defined as def", fn ->
defmodule OverridenFunUsage do
def foo(bar), do: bar
defguard foo(bar) when bar
end
end
assert_raise CompileError, ~r"defmacro (.*?) already defined as defp", fn ->
defmodule OverridenPrivateFunUsage do
defp foo(bar), do: bar
defguard foo(bar) when bar
end
end
assert_raise CompileError, ~r"defmacro (.*?) already defined as defmacrop", fn ->
defmodule OverridenPrivateFunUsage do
defmacrop foo(bar), do: bar
defguard foo(bar) when bar
end
end
assert_raise CompileError, ~r"defmacrop (.*?) already defined as def", fn ->
defmodule OverridenFunUsage do
def foo(bar), do: bar
defguardp foo(bar) when bar
end
end
assert_raise CompileError, ~r"defmacrop (.*?) already defined as defp", fn ->
defmodule OverridenPrivateFunUsage do
defp foo(bar), do: bar
defguardp foo(bar) when bar
end
end
assert_raise CompileError, ~r"defmacrop (.*?) already defined as defmacro", fn ->
defmodule OverridenPrivateFunUsage do
defmacro foo(bar), do: bar
defguardp foo(bar) when bar
end
end
end
test "does not allow multiple guard clauses" do
assert_raise ArgumentError, ~r"invalid syntax in defguard", fn ->
defmodule MultiGuardUsage do
defguardp foo(bar, baz) when bar == 1 when baz == 2
end
end
end
test "does not accept a block" do
assert_raise CompileError, ~r"undefined function defguard/2", fn ->
defmodule OnelinerBlockUsage do
defguard(foo(bar), do: one_liner)
end
end
assert_raise CompileError, ~r"undefined function defguard/2", fn ->
defmodule MultilineBlockUsage do
defguard foo(bar) do
multi
liner
end
end
end
assert_raise CompileError, ~r"undefined function defguard/2", fn ->
defmodule ImplAndBlockUsage do
defguard(foo(bar) when both_given, do: error)
end
end
end
end
describe "Kernel.defguard compilation" do
test "refuses to compile non-sensical code" do
assert_raise CompileError, ~r"cannot invoke local undefined/1 inside guard", fn ->
defmodule UndefinedUsage do
defguard foo(function) when undefined(function)
end
end
end
test "fails on expressions not allowed in guards" do
# Slightly unique errors
assert_raise ArgumentError, ~r{invalid args for operator "in"}, fn ->
defmodule RuntimeListUsage do
defguard foo(bar, baz) when bar in baz
end
end
assert_raise CompileError, ~r"cannot invoke remote function", fn ->
defmodule BadErlangFunctionUsage do
defguard foo(bar) when :erlang.binary_to_atom("foo")
end
end
assert_raise CompileError, ~r"cannot invoke remote function", fn ->
defmodule SendUsage do
defguard foo(bar) when send(self(), :baz)
end
end
# Consistent errors
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule SoftNegationLogicUsage do
defguard foo(logic) when !logic
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule SoftAndLogicUsage do
defguard foo(soft, logic) when soft && logic
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule SoftOrLogicUsage do
defguard foo(soft, logic) when soft || logic
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule LocalCallUsage do
defguard foo(local, call) when local.(call)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule ComprehensionUsage do
defguard foo(bar) when for(x <- [1, 2, 3], do: x * bar)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule AliasUsage do
defguard foo(bar) when alias(bar)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule ImportUsage do
defguard foo(bar) when import(bar)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule RequireUsage do
defguard foo(bar) when require(bar)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule SuperUsage do
defguard foo(bar) when super(bar)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule SpawnUsage do
defguard foo(bar) when spawn(& &1)
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule ReceiveUsage do
defguard foo(bar) when receive(do: (baz -> baz))
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule CaseUsage do
defguard foo(bar) when case(bar, do: (baz -> :baz))
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule CondUsage do
defguard foo(bar) when cond(do: (bar -> :baz))
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule TryUsage do
defguard foo(bar) when try(do: (baz -> baz))
end
end
assert_raise CompileError, ~r"invalid expression in guard", fn ->
defmodule WithUsage do
defguard foo(bar) when with(do: (baz -> baz))
end
end
end
end
describe "Kernel.Utils.defguard/2" do
test "generates unquoted variables based on context" do
args = quote(do: [foo, bar, baz])
expr = quote(do: foo + bar + baz)
{:ok, goal} =
Code.string_to_quoted("""
case Macro.Env.in_guard? __CALLER__ do
true -> quote do
:erlang.+(:erlang.+(unquote(foo), unquote(bar)), unquote(baz))
end
false -> quote do
{foo, bar, baz} = {unquote(foo), unquote(bar), unquote(baz)}
:erlang.+(:erlang.+(foo, bar), baz)
end
end
""")
assert expand_defguard_to_string(args, expr) == Macro.to_string(goal)
end
test "doesn't obscure unused variables" do
args = quote(do: [foo, bar, baz])
expr = quote(do: foo + bar)
{:ok, goal} =
Code.string_to_quoted("""
case Macro.Env.in_guard? __CALLER__ do
true -> quote do
:erlang.+(unquote(foo), unquote(bar))
end
false -> quote do
{foo, bar} = {unquote(foo), unquote(bar)}
:erlang.+(foo, bar)
end
end
""")
assert expand_defguard_to_string(args, expr) == Macro.to_string(goal)
end
test "handles re-used variables" do
args = quote(do: [foo, bar, baz])
expr = quote(do: foo + foo + bar + baz)
{:ok, goal} =
Code.string_to_quoted("""
case(Macro.Env.in_guard?(__CALLER__)) do
true ->
quote() do
:erlang.+(:erlang.+(:erlang.+(unquote(foo), unquote(foo)), unquote(bar)), unquote(baz))
end
false ->
quote() do
{foo, bar, baz} = {unquote(foo), unquote(bar), unquote(baz)}
:erlang.+(:erlang.+(:erlang.+(foo, foo), bar), baz)
end
end
""")
assert expand_defguard_to_string(args, expr) == Macro.to_string(goal)
end
defp expand_defguard_to_string(args, expr) do
require Kernel.Utils
quote(do: Kernel.Utils.defguard(unquote(args), unquote(expr)))
|> Macro.expand(__ENV__)
|> Macro.to_string()
end
end
end
|