diff options
| author | Alan Mackenzie <acm@muc.de> | 2018-01-27 22:02:45 +0000 |
|---|---|---|
| committer | Alan Mackenzie <acm@muc.de> | 2018-01-27 22:02:45 +0000 |
| commit | 6415b2d40c13be2c5cd5f797718c391d1c4ce9e6 (patch) | |
| tree | f9ab154a3e4d1143249562cfc2e1bca55e24dc5e | |
| parent | 8cb4ffb26208b855729aadc09b0e5a9306930c7b (diff) | |
| download | emacs-6415b2d40c13be2c5cd5f797718c391d1c4ce9e6.tar.gz | |
Allow read-passwd to hide characters inserted by C-y. (Security fix.)
This fixes bug #30186. The with-silent-modifications was there to prevent
records of text property manipulations being put into buffer-undo-list. These
had been causing a significant slowdown in CC Mode with C-_ after a large
C-y. This CC Mode problem has since been solved by a different workaround.
* lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of
with-silent-modifications around the text property manipulations.
| -rw-r--r-- | lisp/subr.el | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lisp/subr.el b/lisp/subr.el index 052d9cd8216..64cbbd52ab8 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3019,10 +3019,9 @@ remove properties specified by `yank-excluded-properties'." run-start prop nil end))) (funcall fun value run-start run-end) (setq run-start run-end))))) - (with-silent-modifications - (if (eq yank-excluded-properties t) - (set-text-properties start end nil) - (remove-list-of-text-properties start end yank-excluded-properties))))) + (if (eq yank-excluded-properties t) + (set-text-properties start end nil) + (remove-list-of-text-properties start end yank-excluded-properties)))) (defvar yank-undo-function) |