diff options
author | Konstantin Kharlamov <Hi-Angel@yandex.ru> | 2019-05-16 00:25:53 +0300 |
---|---|---|
committer | Noam Postavsky <npostavs@gmail.com> | 2019-05-16 20:25:32 -0400 |
commit | 2bdc419f51630eb433deb139da67e419000c7694 (patch) | |
tree | e8aa4bab2a61a0f06e402fa4263ab430032afd2a /build-aux | |
parent | cf5457764c1288ee34e01d82deb596950fc9f885 (diff) | |
download | emacs-2bdc419f51630eb433deb139da67e419000c7694.tar.gz |
Do potentially destructive operations in prepare-commit-msg
* build-aux/git-hooks/prepare-commit-msg: If someone occasionally puts
Signed-off line, it will likely get there through -s option of git.
Exploit this fact to abort before a user got a chance to type commit
message. (Bug#35368)
Diffstat (limited to 'build-aux')
-rwxr-xr-x | build-aux/git-hooks/prepare-commit-msg | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/build-aux/git-hooks/prepare-commit-msg b/build-aux/git-hooks/prepare-commit-msg new file mode 100755 index 00000000000..3562a802234 --- /dev/null +++ b/build-aux/git-hooks/prepare-commit-msg @@ -0,0 +1,45 @@ +#!/bin/sh +# Check the format of GNU Emacs change log entries. + +# Copyright 2019 Free Software Foundation, Inc. + +# This file is part of GNU Emacs. + +# GNU Emacs is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# GNU Emacs is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. + +COMMIT_MSG_FILE=$1 +COMMIT_SOURCE=$2 +SHA1=$3 + +# Prefer gawk if available, as it handles NUL bytes properly. +if type gawk >/dev/null 2>&1; then + awk=gawk +else + awk=awk +fi + +exec $awk ' + # Catch the case when someone ran git-commit with -s option, + # which automatically adds Signed-off-by. + /^Signed-off-by: / { + print "'\''Signed-off-by:'\'' in commit message" + status = 1 + } + END { + if (status != 0) { + print "Commit aborted; please see the file 'CONTRIBUTE'" + } + exit status + } +' <"$COMMIT_MSG_FILE" |