summaryrefslogtreecommitdiff
path: root/lisp/minibuffer.el
diff options
context:
space:
mode:
authorGlenn Morris <rgm@gnu.org>2014-03-04 09:01:37 -0800
committerGlenn Morris <rgm@gnu.org>2014-03-04 09:01:37 -0800
commit3106d59bce024deba9d6b2193531c09b6a6d3c91 (patch)
treeade312409361ba1cd6ac9b18aa728e548288c959 /lisp/minibuffer.el
parentf604dfdc367bf4c628c2c2b6b44ac00eed1f1589 (diff)
downloademacs-3106d59bce024deba9d6b2193531c09b6a6d3c91.tar.gz
* minibuffer.el (completion-hilit-commonality): Revert 2014-03-01 short-cut,
which changed the return value. Fixes: debbugs:16933
Diffstat (limited to 'lisp/minibuffer.el')
-rw-r--r--lisp/minibuffer.el58
1 files changed, 28 insertions, 30 deletions
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index da3a8ad9df1..526fdb62bc3 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1597,36 +1597,34 @@ This adds the face `completions-common-part' to the first
It returns a list with font-lock properties applied to each element,
and with BASE-SIZE appended as the last element."
(when completions
- (if (zerop prefix-len)
- completions
- (let ((com-str-len (- prefix-len (or base-size 0))))
- (nconc
- (mapcar
- (lambda (elem)
- (let ((str
- ;; Don't modify the string itself, but a copy, since the
- ;; the string may be read-only or used for other purposes.
- ;; Furthermore, since `completions' may come from
- ;; display-completion-list, `elem' may be a list.
- (if (consp elem)
- (car (setq elem (cons (copy-sequence (car elem))
- (cdr elem))))
- (setq elem (copy-sequence elem)))))
- (font-lock-prepend-text-property
- 0
- ;; If completion-boundaries returns incorrect
- ;; values, all-completions may return strings
- ;; that don't contain the prefix.
- (min com-str-len (length str))
- 'face 'completions-common-part str)
- (if (> (length str) com-str-len)
- (font-lock-prepend-text-property com-str-len (1+ com-str-len)
- 'face
- 'completions-first-difference
- str)))
- elem)
- completions)
- base-size)))))
+ (let ((com-str-len (- prefix-len (or base-size 0))))
+ (nconc
+ (mapcar
+ (lambda (elem)
+ (let ((str
+ ;; Don't modify the string itself, but a copy, since the
+ ;; the string may be read-only or used for other purposes.
+ ;; Furthermore, since `completions' may come from
+ ;; display-completion-list, `elem' may be a list.
+ (if (consp elem)
+ (car (setq elem (cons (copy-sequence (car elem))
+ (cdr elem))))
+ (setq elem (copy-sequence elem)))))
+ (font-lock-prepend-text-property
+ 0
+ ;; If completion-boundaries returns incorrect
+ ;; values, all-completions may return strings
+ ;; that don't contain the prefix.
+ (min com-str-len (length str))
+ 'face 'completions-common-part str)
+ (if (> (length str) com-str-len)
+ (font-lock-prepend-text-property com-str-len (1+ com-str-len)
+ 'face
+ 'completions-first-difference
+ str)))
+ elem)
+ completions)
+ base-size))))
(defun display-completion-list (completions &optional common-substring)
"Display the list of completions, COMPLETIONS, using `standard-output'.