diff options
| author | Simen Heggestøyl <simenheg@gmail.com> | 2016-04-24 19:57:42 +0200 |
|---|---|---|
| committer | Simen Heggestøyl <simenheg@gmail.com> | 2016-04-24 19:58:36 +0200 |
| commit | e6d6a99455183bca5074b7601ad11d424da6442e (patch) | |
| tree | 37d78fa65347b299f1fad95520ae9e5959220529 /test/lisp/textmodes/css-mode-tests.el | |
| parent | 12846626bfae795a173fdedf2850dfbd24065534 (diff) | |
| download | emacs-e6d6a99455183bca5074b7601ad11d424da6442e.tar.gz | |
Don't let `css--property-values' return duplicates
* lisp/textmodes/css-mode.el (css--property-values): Don't return
duplicate values.
* test/lisp/textmodes/css-mode-tests.el (css-test-property-values):
Take the above into account.
(css-test-property-values-no-duplicates): Test that duplicates aren't
returned by `css--property-values'.
Diffstat (limited to 'test/lisp/textmodes/css-mode-tests.el')
| -rw-r--r-- | test/lisp/textmodes/css-mode-tests.el | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/test/lisp/textmodes/css-mode-tests.el b/test/lisp/textmodes/css-mode-tests.el index 805364c9f42..5d5873b301b 100644 --- a/test/lisp/textmodes/css-mode-tests.el +++ b/test/lisp/textmodes/css-mode-tests.el @@ -24,8 +24,9 @@ ;;; Code: -(require 'ert) (require 'css-mode) +(require 'ert) +(require 'seq) (ert-deftest css-test-property-values () ;; The `float' property has a flat value list. @@ -36,9 +37,10 @@ ;; The `list-style' property refers to several other properties. (should (equal (sort (css--property-values "list-style") #'string-lessp) - (sort (append (css--property-values "list-style-type") - (css--property-values "list-style-position") - (css--property-values "list-style-image")) + (sort (seq-uniq + (append (css--property-values "list-style-type") + (css--property-values "list-style-position") + (css--property-values "list-style-image"))) #'string-lessp))) ;; The `position' property is tricky because it's also the name of a @@ -64,6 +66,14 @@ (should (equal (gethash "word-wrap" css--property-value-cache) word-wrap-values)))) +(ert-deftest css-test-property-values-no-duplicates () + "Test that `css--property-values' returns no duplicates." + ;; The `flex' property is prone to duplicate values; if they aren't + ;; removed, it'll contain at least two instances of `auto'. + (should + (equal (sort (css--property-values "flex") #'string-lessp) + '("auto" "content" "none")))) + (ert-deftest css-test-value-class-lookup () (should (equal (sort (css--value-class-lookup 'position) #'string-lessp) |