From 68cc286c0495caaebc3f641f6b919109045c43dd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
Date: Tue, 28 Feb 2023 17:07:06 +0100
Subject: Fix some useless condition-case forms

* lisp/progmodes/cperl-mode.el (cperl-calculate-indent):
* lisp/progmodes/verilog-mode.el (verilog--suppressed-warnings):
Add error handler, seemingly the intention here.
* lisp/url/url-gw.el (url-open-stream): Remove condition-case;
it was neutered in 2006.
---
 lisp/progmodes/cperl-mode.el   |  5 ++--
 lisp/progmodes/verilog-mode.el |  3 ++-
 lisp/url/url-gw.el             | 57 +++++++++++++++++++++---------------------
 3 files changed, 33 insertions(+), 32 deletions(-)

diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index 412283f3488..b6f0e9bca41 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -2918,8 +2918,9 @@ and closing parentheses and brackets."
 	 ;;
 	 ((eq 'REx-part2 (elt i 0)) ;; [self start] start of /REP in s//REP/x
 	  (goto-char (elt i 1))
-	  (condition-case nil	; Use indentation of the 1st part
-	      (forward-sexp -1))
+          (condition-case nil
+	      (forward-sexp -1) 	; Use indentation of the 1st part
+            (error nil))
 	  (current-column))
 	 ((eq 'indentable (elt i 0))	; Indenter for REGEXP qw() etc
 	  (cond		       ;;; [indentable terminator start-pos is-block]
diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el
index 2989d7ddb61..ac6fd382a46 100644
--- a/lisp/progmodes/verilog-mode.el
+++ b/lisp/progmodes/verilog-mode.el
@@ -370,7 +370,8 @@ wherever possible, since it is slow."
       (unless (fboundp 'ignore-errors)
         (defmacro ignore-errors (&rest body)
           (declare (debug t) (indent 0))
-          `(condition-case nil (progn ,@body) (error nil)))))
+          `(condition-case nil (progn ,@body) (error nil))))
+    (error nil))
   ;; Added in Emacs 24.1
   (condition-case nil
       (unless (fboundp 'prog-mode)
diff --git a/lisp/url/url-gw.el b/lisp/url/url-gw.el
index b20e5073f74..f16be980945 100644
--- a/lisp/url/url-gw.el
+++ b/lisp/url/url-gw.el
@@ -239,35 +239,34 @@ overriding the value of `url-gateway-method'."
       (if url-gateway-broken-resolution
 	  (setq host (url-gateway-nslookup-host host)))
 
-      (condition-case nil
-	  ;; This is a clean way to ensure the new process inherits the
-	  ;; right coding systems in both Emacs and XEmacs.
-	  (let ((coding-system-for-read 'binary)
-		(coding-system-for-write 'binary))
-	    (setq conn (pcase gw-method
-			 ((or 'tls 'ssl 'native)
-			  (if (eq gw-method 'native)
-			      (setq gw-method 'plain))
-			  (open-network-stream
-			   name buffer host service
-			   :type gw-method
-			   ;; Use non-blocking socket if we can.
-			   :nowait (and (featurep 'make-network-process)
-                                        (url-asynchronous url-current-object)
-                                        '(:nowait t))))
-                         ('socks
-			  (socks-open-network-stream name buffer host service))
-			 ('telnet
-			  (url-open-telnet name buffer host service))
-			 ('rlogin
-                          (unless url-gw-rlogin-obsolete-warned-once
-                            (lwarn 'url :error "Setting `url-gateway-method' to `rlogin' is obsolete")
-                            (setq url-gw-rlogin-obsolete-warned-once t))
-                          (with-suppressed-warnings ((obsolete url-open-rlogin))
-                            (url-open-rlogin name buffer host service)))
-			 (_
-			  (error "Bad setting of url-gateway-method: %s"
-				 url-gateway-method))))))
+      ;; This is a clean way to ensure the new process inherits the
+      ;; right coding systems in both Emacs and XEmacs.
+      (let ((coding-system-for-read 'binary)
+	    (coding-system-for-write 'binary))
+	(setq conn (pcase gw-method
+		     ((or 'tls 'ssl 'native)
+		      (if (eq gw-method 'native)
+			  (setq gw-method 'plain))
+		      (open-network-stream
+		       name buffer host service
+		       :type gw-method
+		       ;; Use non-blocking socket if we can.
+		       :nowait (and (featurep 'make-network-process)
+                                    (url-asynchronous url-current-object)
+                                    '(:nowait t))))
+                     ('socks
+		      (socks-open-network-stream name buffer host service))
+		     ('telnet
+		      (url-open-telnet name buffer host service))
+		     ('rlogin
+                      (unless url-gw-rlogin-obsolete-warned-once
+                        (lwarn 'url :error "Setting `url-gateway-method' to `rlogin' is obsolete")
+                        (setq url-gw-rlogin-obsolete-warned-once t))
+                      (with-suppressed-warnings ((obsolete url-open-rlogin))
+                        (url-open-rlogin name buffer host service)))
+		     (_
+		      (error "Bad setting of url-gateway-method: %s"
+			     url-gateway-method)))))
       conn)))
 
 (provide 'url-gw)
-- 
cgit v1.2.1