diff options
| author | Woochanlee <wc0917.lee@samsung.com> | 2020-09-17 17:23:41 +0900 |
|---|---|---|
| committer | Hermet Park <chuneon.park@samsung.com> | 2020-09-17 17:23:42 +0900 |
| commit | 875f05cef53a973eee7fe25abdbcb824896f9d0e (patch) | |
| tree | d891cbcbdcc20df3e00041cf8d37af5daedd6926 | |
| parent | ca2900be8a109e3e205a8c49ff11a1f822ae96b7 (diff) | |
| download | efl-875f05cef53a973eee7fe25abdbcb824896f9d0e.tar.gz | |
evas_outbuf: Fix memory leak.
Summary: In certain use cases, when image data is created twice, the existing memory pointer is isolated and a memory leak occurs.
Reviewers: raster, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8813
Differential Revision: https://phab.enlightenment.org/D12148
| -rw-r--r-- | src/modules/evas/engines/buffer/evas_outbuf.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/modules/evas/engines/buffer/evas_outbuf.c b/src/modules/evas/engines/buffer/evas_outbuf.c index 545ff096ed..d143179f21 100644 --- a/src/modules/evas/engines/buffer/evas_outbuf.c +++ b/src/modules/evas/engines/buffer/evas_outbuf.c @@ -45,8 +45,9 @@ evas_buffer_outbuf_buf_update_fb(Outbuf *buf, int w, int h, Outbuf_Depth depth, if ((buf->depth == OUTBUF_DEPTH_ARGB_32BPP_8888_8888) && (buf->dest) && (buf->dest_row_bytes == (buf->w * sizeof(DATA32)))) { - memset(buf->dest, 0, h * buf->dest_row_bytes); - buf->priv.back_buf = + memset(buf->dest, 0, h * buf->dest_row_bytes); + if (buf->priv.back_buf) evas_cache_image_drop(&buf->priv.back_buf->cache_entry); + buf->priv.back_buf = (RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(), w, h, buf->dest, 1, EVAS_COLORSPACE_ARGB8888); @@ -54,6 +55,7 @@ evas_buffer_outbuf_buf_update_fb(Outbuf *buf, int w, int h, Outbuf_Depth depth, else if ((buf->depth == OUTBUF_DEPTH_RGB_32BPP_888_8888) && (buf->dest) && (buf->dest_row_bytes == (buf->w * sizeof(DATA32)))) { + if (buf->priv.back_buf) evas_cache_image_drop(&buf->priv.back_buf->cache_entry); buf->priv.back_buf = (RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(), w, h, buf->dest, |