diff options
author | JunsuChoi <jsuya.choi@samsung.com> | 2020-05-12 11:20:25 -0400 |
---|---|---|
committer | Mike Blumenkrantz <zmike@samsung.com> | 2020-05-12 11:21:01 -0400 |
commit | feccff1ca7cd2dc941b9bf92b5999858f5d72a41 (patch) | |
tree | b168da264b0bf1467a9c3f32da8ffef32b7629b9 | |
parent | 183fa33fd0adfdc7b1d1b8a05230943b12382776 (diff) | |
download | efl-feccff1ca7cd2dc941b9bf92b5999858f5d72a41.tar.gz |
Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents
Summary:
When call elm_radio_add, theme_apply of layout is called and
_efl_ui_radio_legacy_efl_ui_widget_theme_apply is called.
Then it calls the signal emit for the icon.
this call is unnecessary.
Test Plan:
Evas_Object *bt;
clock_t start, finish;
double sum= 0 ;
double avg = 0;
double cnt = 1000;
for(int i =0 ; i<(int)cnt; i++)
{
start = clock();
bt = elm_radio_add(win);
finish = clock();
sum += (double)(finish-start)/CLOCKS_PER_SEC;
}
avg = sum / cnt ;
printf("radio avg : %f\n",avg);
[before]
radio avg : 0.000232
[after]
radio avg : 0.000197
Reviewers: akanad, Jaehyun_Cho, Hermet, YOhoho, zmike
Reviewed By: zmike
Subscribers: bu5hm4n, zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11813
-rw-r--r-- | src/lib/elementary/efl_ui_radio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/elementary/efl_ui_radio.c b/src/lib/elementary/efl_ui_radio.c index e631cb81f3..34a82c737c 100644 --- a/src/lib/elementary/efl_ui_radio.c +++ b/src/lib/elementary/efl_ui_radio.c @@ -365,7 +365,7 @@ _efl_ui_radio_legacy_efl_ui_widget_theme_apply(Eo *obj, void *_pd EINA_UNUSED) /* FIXME: replicated from elm_layout just because radio's icon * spot is elm.swallow.content, not elm.swallow.icon. Fix that * whenever we can changed the theme API */ - _icon_signal_emit(obj); + if (efl_finalized_get(obj)) _icon_signal_emit(obj); return int_ret; } |