summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2019-06-20 12:08:14 +0100
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2019-06-20 12:08:14 +0100
commit33f5e53af3cf059b234f4e618f573ac6b354f7c6 (patch)
treecfd9bf433f41324713ea6ae60b15faa7932e11a9
parent471c4bebb592bc11f7acc001166075a8721ebb0b (diff)
downloadefl-33f5e53af3cf059b234f4e618f573ac6b354f7c6.tar.gz
evas - events - protect on object deletion while calling callbacks
mouse in/out feeds can call callabcks that can then go delete objects - ref them all to ensure they stay alive while we use them. this will fix a segv apbbb saw.
-rw-r--r--src/lib/evas/canvas/evas_events.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/lib/evas/canvas/evas_events.c b/src/lib/evas/canvas/evas_events.c
index ee31ef5ac2..9dfa24ca39 100644
--- a/src/lib/evas/canvas/evas_events.c
+++ b/src/lib/evas/canvas/evas_events.c
@@ -2610,6 +2610,7 @@ _canvas_event_feed_mouse_in_internal(Evas *eo_e, Efl_Input_Pointer_Data *ev)
{
Evas_Object_Pointer_Data *obj_pdata;
Evas_Object_Protected_Data *obj = efl_data_scope_get(eo_obj, EFL_CANVAS_OBJECT_CLASS);
+ if ((!obj) || (obj->delete_me)) continue;
if (!eina_list_data_find(pdata->seat->object.in, eo_obj))
{
obj_pdata = _evas_object_pointer_data_get(pdata, obj);
@@ -2625,6 +2626,7 @@ _canvas_event_feed_mouse_in_internal(Evas *eo_e, Efl_Input_Pointer_Data *ev)
ev->cur.y = pdata->seat->y;
_evas_event_havemap_adjust_f(eo_obj, obj, &ev->cur, obj_pdata->mouse_grabbed);
ev->action = EFL_POINTER_ACTION_IN;
+ efl_ref(eo_obj);
evas_object_event_callback_call(eo_obj, obj, EVAS_CALLBACK_MOUSE_IN, evt,
event_id, EFL_EVENT_POINTER_IN);
if ((pdata->seat->x != ev->prev.x) &&
@@ -2636,6 +2638,7 @@ _canvas_event_feed_mouse_in_internal(Evas *eo_e, Efl_Input_Pointer_Data *ev)
}
if ((obj->proxy->is_proxy) && (obj->proxy->src_events))
_evas_event_source_mouse_in_events(eo_obj, eo_e, evt, event_id);
+ efl_unref(eo_obj);
if (e->delete_me || e->is_frozen) break;
}
}
@@ -2708,7 +2711,7 @@ _canvas_event_feed_mouse_out_internal(Evas *eo_e, Efl_Input_Pointer_Data *ev)
{
Evas_Object_Pointer_Data *obj_pdata;
Evas_Object_Protected_Data *obj = efl_data_scope_get(eo_obj, EFL_CANVAS_OBJECT_CLASS);
- if (obj->delete_me) continue;
+ if ((!obj) || (obj->delete_me)) continue;
obj_pdata = _evas_object_pointer_data_get(pdata, obj);
if (!obj_pdata)
{
@@ -2720,11 +2723,13 @@ _canvas_event_feed_mouse_out_internal(Evas *eo_e, Efl_Input_Pointer_Data *ev)
_evas_event_mouse_in_set(pdata->seat, obj, 0);
ev->cur.x = pdata->seat->x;
ev->cur.y = pdata->seat->y;
+ efl_ref(eo_obj);
_evas_event_havemap_adjust_f(eo_obj, obj, &ev->cur, obj_pdata->mouse_grabbed);
evas_object_event_callback_call(eo_obj, obj, EVAS_CALLBACK_MOUSE_OUT, evt,
event_id, EFL_EVENT_POINTER_OUT);
if ((obj->proxy->is_proxy) && (obj->proxy->src_events))
_evas_event_source_mouse_out_events(eo_obj, eo_e, evt, event_id);
+ efl_unref(eo_obj);
if (e->delete_me || e->is_frozen) break;
obj_pdata->mouse_grabbed = 0;
}