diff options
| author | Mike Blumenkrantz <zmike@osg.samsung.com> | 2016-01-25 11:24:54 -0500 |
|---|---|---|
| committer | Mike Blumenkrantz <zmike@osg.samsung.com> | 2016-01-25 11:27:02 -0500 |
| commit | 200f45c2b5841133d3999c6b16c980be0d8a04f2 (patch) | |
| tree | 196911ed674eeddc77a3d9a03c886eeb07131259 | |
| parent | 9aee7c249a8ef237dbc617474c0e45dea8a42475 (diff) | |
| download | efl-200f45c2b5841133d3999c6b16c980be0d8a04f2.tar.gz | |
efreet: add locking for efreet_desktop_x_field_get()
in a threaded environment, reading from a hash is not atomic and is
subject to race conditions
@fix
ref 39417cf0ea4e457fbc8d50d120bb8ac776aa366f
| -rw-r--r-- | src/lib/efreet/efreet_desktop.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/efreet/efreet_desktop.c b/src/lib/efreet/efreet_desktop.c index f3cef0c98a..78d0f514cb 100644 --- a/src/lib/efreet/efreet_desktop.c +++ b/src/lib/efreet/efreet_desktop.c @@ -537,8 +537,10 @@ efreet_desktop_x_field_get(Efreet_Desktop *desktop, const char *key) EINA_SAFETY_ON_NULL_RETURN_VAL(desktop->x, NULL); EINA_SAFETY_ON_TRUE_RETURN_VAL(strncmp(key, "X-", 2), NULL); + eina_lock_take(&_lock); ret = eina_hash_find(desktop->x, key); ret = eina_stringshare_add(ret); + eina_lock_release(&_lock); if (ret && (!ret[0])) { /* invalid null key somehow accepted; remove */ |