diff options
| author | Guilherme Iscaro <iscaro@profusion.mobi> | 2017-08-02 16:47:11 -0300 |
|---|---|---|
| committer | Guilherme Iscaro <iscaro@profusion.mobi> | 2017-08-02 17:06:39 -0300 |
| commit | 32bb5f31e26566b298635ce9948c8492d5b3f32d (patch) | |
| tree | 5ba73eb209fab2f6aa561b69994f14e6e942bc06 | |
| parent | 91ea8f5b12f47aca664d93cfc027c8bd7215aac8 (diff) | |
| download | efl-devs/iscaro/copier_file.tar.gz | |
Efl_Copier: Add efl_wref_del() for pd->job.devs/iscaro/copier_file
In order to perform IO operations the copier will create futures using
efl_future_use(&pd->job, ...), which will set pd->job to NULL once the
future is destroyed. However this may lead to problems, because in some
cases the copier may be deleted at the _efl_io_copier_job() function,
which is the future's callback. Since the copier may be deleted before
the future, the area pointed by pd->job will have disappeared by the time the future
tries to set pd->job to NULL. To avoid this problem the copier must
explicily call efl_wref_del().
| -rw-r--r-- | src/lib/ecore/efl_io_copier.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/ecore/efl_io_copier.c b/src/lib/ecore/efl_io_copier.c index c43ca0c3b6..0f744d6eb4 100644 --- a/src/lib/ecore/efl_io_copier.c +++ b/src/lib/ecore/efl_io_copier.c @@ -100,6 +100,8 @@ _efl_io_copier_job(void *data, const Efl_Event *ev EINA_UNUSED) uint64_t old_total = pd->progress.total; _COPIER_DBG(o, pd); + /* FIXME: Remove this wref once efl_promise is able to handle recursive cases. */ + efl_wref_del(pd->job, &pd->job); pd->job = NULL; /* XXX TODO this should be NULL-ified by efl_promise before calling this function */ efl_ref(o); |