diff options
| author | Artem Popov <artem.popov@samsung.com> | 2016-11-24 12:13:36 +0900 |
|---|---|---|
| committer | Hermet Park <hermet@hermet.pe.kr> | 2016-11-24 12:13:36 +0900 |
| commit | 7372b1d156ec989655204a2b409281a6996fd88c (patch) | |
| tree | f8741557d31a646d7975ddbd84cc70475d7c43f5 | |
| parent | 791bdcb7b23e517fc9e2afd68b701323f94d778b (diff) | |
| download | efl-7372b1d156ec989655204a2b409281a6996fd88c.tar.gz | |
Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get()
@fix
Summary: add checking on NULL 3-rd parameter (param) before strcmp to avoid segfault
Reviewers: cedric, jpeg, NikaWhite, myoungwoon, Hermet
Reviewed By: Hermet
Subscribers: Hermet, t.naumenko
Differential Revision: https://phab.enlightenment.org/D4424
| -rw-r--r-- | src/lib/edje/edje_external.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/edje/edje_external.c b/src/lib/edje/edje_external.c index 9065f94486..8e242f1467 100644 --- a/src/lib/edje/edje_external.c +++ b/src/lib/edje/edje_external.c @@ -124,7 +124,7 @@ _edje_object_part_external_param_type_get(Eo *obj, Edje *ed, const char *part, c Edje_External_Type *type; Edje_External_Param_Info *info; - if ((!ed) || (!part)) return EDJE_EXTERNAL_PARAM_TYPE_MAX; + if ((!ed) || (!part) || (!param)) return EDJE_EXTERNAL_PARAM_TYPE_MAX; rp = _edje_real_part_recursive_get(&ed, (char *)part); if (!rp) @@ -147,7 +147,7 @@ _edje_object_part_external_param_type_get(Eo *obj, Edje *ed, const char *part, c return EDJE_EXTERNAL_PARAM_TYPE_MAX; } for (info = type->parameters_info; info->name; info++) - if (strcmp(info->name, param) == 0) return info->type; ; + if (strcmp(info->name, param) == 0) return info->type; ERR("no parameter '%s' external type '%s'", param, type->module_name); |