diff options
| author | Christopher Michael <cp.michael@samsung.com> | 2019-03-15 08:57:44 -0400 |
|---|---|---|
| committer | Christopher Michael <cp.michael@samsung.com> | 2019-03-15 08:57:44 -0400 |
| commit | 0f1f5dabf35dc4046308e5832a74d682f52f5684 (patch) | |
| tree | d6a63e2bd154d0147e5ebaf5c8879012d88404e2 | |
| parent | 384d960852b9e2b6fbf90d448c70757dd1b644cf (diff) | |
| download | efl-0f1f5dabf35dc4046308e5832a74d682f52f5684.tar.gz | |
efl_ui_win: Fix dereference null return
Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check here before
trying to use 'sd'.
Fixes Coverity CID1399427
@fix
Depends on D8346
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8347
| -rw-r--r-- | src/lib/elementary/efl_ui_win.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c index c468d62d12..0bc039b8a1 100644 --- a/src/lib/elementary/efl_ui_win.c +++ b/src/lib/elementary/efl_ui_win.c @@ -9245,6 +9245,7 @@ EAPI Eina_Bool elm_win_noblank_get(const Evas_Object *obj) { Efl_Ui_Win_Data *sd = efl_data_scope_safe_get(obj, MY_CLASS); + EINA_SAFETY_ON_NULL_RETURN_VAL(sd, EINA_FALSE); return sd->noblank; } |