summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristopher Michael <cp.michael@samsung.com>2019-03-12 10:11:21 -0400
committerMarcel Hollerbach <mail@marcel-hollerbach.de>2019-03-13 16:55:08 +0100
commit62d7d8a418df461f61600ff7eafc70a02d8ef2b5 (patch)
treedca463ffcb222b444b26e5fde6e4f00ef2073bab
parent3cdb7df50b7a06929236df30bff7f8f8b1453ea4 (diff)
downloadefl-62d7d8a418df461f61600ff7eafc70a02d8ef2b5.tar.gz
efl_ui_selection_manager: Fix unchecked return value
This patch fixes an issue where the return value from ecore_x_init is not checked. If we fail to initialize ecore_x, then we should print out an error and get out. Fixes Coverity CID1399092 @fix Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D8312
-rw-r--r--src/lib/elementary/efl_ui_selection_manager.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/lib/elementary/efl_ui_selection_manager.c b/src/lib/elementary/efl_ui_selection_manager.c
index 7b06cfc142..2c401df14b 100644
--- a/src/lib/elementary/efl_ui_selection_manager.c
+++ b/src/lib/elementary/efl_ui_selection_manager.c
@@ -5179,7 +5179,11 @@ _efl_ui_selection_manager_efl_object_constructor(Eo *obj, Efl_Ui_Selection_Manag
}
if (init_x)
{
- ecore_x_init(NULL);
+ if (!ecore_x_init(NULL))
+ {
+ ERR("Could not initialize Ecore_X");
+ return NULL;
+ }
}
#endif
#ifdef HAVE_ELEMENTARY_WL2