diff options
author | WooHyun Jung <wh0705.jung@samsung.com> | 2020-05-12 16:46:29 +0900 |
---|---|---|
committer | WooHyun Jung <wh0705.jung@samsung.com> | 2020-05-12 16:46:29 +0900 |
commit | 8538130ba27f23108bcf6cbada75781784612d0f (patch) | |
tree | f0ab076eaf2e90a224c96765105433c3f34e9bbe | |
parent | 9d9658304993f1fe56c052575875f2619a64e435 (diff) | |
download | efl-8538130ba27f23108bcf6cbada75781784612d0f.tar.gz |
evas_object_textblock: fix to free style properly by edje's style_user_pop
Summary:
When calling style_user_pop in edje, current style was not freed by
style_user_pop in evas properly (since old_ts was not cared at all).
Because of this, memory was leaked by none accessible textblock styles which
should have been freed.
@fix
Test Plan:
1. call edje_object_part_text_style_user_pop
2. call edje_object_part_text_style_user_push with new style-text
3. repeat #1 and #2 several times and check the memory (ps -u)
Reviewers: ali.alzyod, bowonryu, bu5hm4n, zmike
Reviewed By: ali.alzyod
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11801
-rw-r--r-- | src/lib/evas/canvas/evas_object_textblock.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c index ea48a10fe7..937cc60263 100644 --- a/src/lib/evas/canvas/evas_object_textblock.c +++ b/src/lib/evas/canvas/evas_object_textblock.c @@ -8219,6 +8219,7 @@ _textblock_style_generic_set(Evas_Object *eo_obj, Evas_Textblock_Style *ts, else if (us) { o->styles = eina_list_remove_list(o->styles, itr); + old_ts = us->st; free(us); } } |