diff options
| author | Marcel Hollerbach <mail@marcel-hollerbach.de> | 2020-04-17 15:17:52 +0200 |
|---|---|---|
| committer | Stefan Schmidt <s.schmidt@samsung.com> | 2020-04-20 12:30:18 +0200 |
| commit | 114412d5478fff07f6c2c7462cb33ed788662475 (patch) | |
| tree | 02544b0a366e56c2d162e117e04f4cb962c8a1a8 | |
| parent | e7f4bc4c2a669973e3796e2f9d3a87c610ded6eb (diff) | |
| download | efl-114412d5478fff07f6c2c7462cb33ed788662475.tar.gz | |
exactness-inspect: remove abscure xor check
this is a obscure check, if this was ever reached, then it would simply
crash, because one pointer will be NULL, but strcmp will be called on
it.
CID 1419854
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11722
| -rw-r--r-- | src/bin/exactness/inspect.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/src/bin/exactness/inspect.c b/src/bin/exactness/inspect.c index 33bcd23533..dcd55b890a 100644 --- a/src/bin/exactness/inspect.c +++ b/src/bin/exactness/inspect.c @@ -326,13 +326,8 @@ _grp_text_get(void *data, Evas_Object *gl, const char *part EINA_UNUSED) Eo *gl2 = eina_list_nth(_gls, 1); Exactness_Unit *unit1 = efl_key_data_get(gl1, "unit"); Exactness_Unit *unit2 = efl_key_data_get(gl2, "unit"); - if (!!unit1->fonts_path || !!unit2->fonts_path) - sprintf(buf2, "Fonts directory comparison: XXXXX"); - else if (!strcmp(unit1->fonts_path, unit2->fonts_path)) - sprintf(buf2, "Fonts directory comparison: %s", unit1->fonts_path); - else - sprintf(buf2, "Fonts directory comparison: "LDIFF(%s)"/"RDIFF(%s), - unit1->fonts_path, unit2->fonts_path); + sprintf(buf2, "Fonts directory comparison: "LDIFF(%s)"/"RDIFF(%s), + unit1 ? unit1->fonts_path : "(NULL)", unit2 ? unit2->fonts_path : "(NULL)"); } return strdup(buf2); } |