diff options
| author | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2020-04-17 12:14:19 +0100 |
|---|---|---|
| committer | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2020-04-17 12:14:19 +0100 |
| commit | 5f93f16b61c34b09f9ce3f1ab7bb8473a81b4d04 (patch) | |
| tree | 18cb7f8e3fb15a3fa1cb8f44762e14379981d47d | |
| parent | 02da386da89e06f6ab7335111848fb94bd358053 (diff) | |
| download | efl-5f93f16b61c34b09f9ce3f1ab7bb8473a81b4d04.tar.gz | |
ecore - proc env - fix values return NULL case - coverity
this fixes CID 1419857
| -rw-r--r-- | src/lib/ecore/efl_core_proc_env.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/lib/ecore/efl_core_proc_env.c b/src/lib/ecore/efl_core_proc_env.c index 3b21015048..f693df25af 100644 --- a/src/lib/ecore/efl_core_proc_env.c +++ b/src/lib/ecore/efl_core_proc_env.c @@ -58,6 +58,8 @@ _sync(Efl_Core_Env *obj, Efl_Core_Proc_Env_Data *pd) char **values; values = eina_str_split(*p, "=", 2); + if (!values) break; + efl_core_env_set(obj, values[0], values[1]); EINA_LIST_FOREACH(existing_keys, n, key) @@ -68,12 +70,8 @@ _sync(Efl_Core_Env *obj, Efl_Core_Proc_Env_Data *pd) break; } } - - if (values) - { - free(values[0]); - free(values); - } + free(values[0]); + free(values); } } EINA_LIST_FOREACH(existing_keys, n, key) |