diff options
| author | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2014-08-14 19:40:54 +0900 |
|---|---|---|
| committer | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2014-08-14 19:40:54 +0900 |
| commit | 257e853407d67cba31af48f3a2e0aa1c30eb85de (patch) | |
| tree | 0353027e5b85874909fa00d54b1aa95dba09951e | |
| parent | 8da87146b49f12e4239872b201a8546918c040fb (diff) | |
| download | efl-257e853407d67cba31af48f3a2e0aa1c30eb85de.tar.gz | |
eio - fix possible stringhare del bug in dir chmod
coverity picked this up - CID 1039645. it does indeed look like a real
bug. if order->dirs is empty. for example.
| -rw-r--r-- | src/lib/eio/eio_dir.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/lib/eio/eio_dir.c b/src/lib/eio/eio_dir.c index 5bd21e1e95..9d0c72e7bf 100644 --- a/src/lib/eio/eio_dir.c +++ b/src/lib/eio/eio_dir.c @@ -305,7 +305,7 @@ _eio_dir_chmod(Ecore_Thread *thread, Eio_Dir_Copy *order, int length_source, int length_dest, Eina_Bool rmdir_source) { - const char *dir; + const char *dir = NULL; char target[PATH_MAX]; struct stat buffer; @@ -343,6 +343,7 @@ _eio_dir_chmod(Ecore_Thread *thread, Eio_Dir_Copy *order, goto on_cancel; eina_stringshare_del(dir); + dir = NULL; } return EINA_TRUE; |