diff options
| author | Chris Michael <cp.michael@samsung.com> | 2016-07-21 12:50:19 -0400 |
|---|---|---|
| committer | Chris Michael <cp.michael@samsung.com> | 2016-07-21 12:50:19 -0400 |
| commit | fb09df7977d6038d0c422494dd2d9926e70a89a9 (patch) | |
| tree | bf4a50c53e501adfc8ae8679fb35c4a9f865eb8d | |
| parent | 4555f5d5940d18f7d5e382803a5e4bd21b461980 (diff) | |
| download | efl-fb09df7977d6038d0c422494dd2d9926e70a89a9.tar.gz | |
eldbus: Check return value and error out if necessary
Coverity reports that we do not check the return value of
_eldbus_model_proxy_load here. We likely should be checking that in
case the model proxy fails to load so we can return proper values here.
Fixes Coverity CID1355233
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
| -rw-r--r-- | src/lib/eldbus/eldbus_model_proxy.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/lib/eldbus/eldbus_model_proxy.c b/src/lib/eldbus/eldbus_model_proxy.c index 43a3779cef..430ccb2282 100644 --- a/src/lib/eldbus/eldbus_model_proxy.c +++ b/src/lib/eldbus/eldbus_model_proxy.c @@ -98,9 +98,13 @@ static Eina_Array const * _eldbus_model_proxy_efl_model_properties_get(Eo *obj EINA_UNUSED, Eldbus_Model_Proxy_Data *pd) { + Eina_Bool ret; + EINA_SAFETY_ON_NULL_RETURN_VAL(pd, NULL); - _eldbus_model_proxy_load(pd); + ret = _eldbus_model_proxy_load(pd); + if (!ret) return NULL; + return pd->properties_array; } |