| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We had here a little problem, state focus_state_eval function handled
the unregisteration and consideration of the focus flags and then only
called a helper function (which was a widget function), that then did
the registeration in logical or regular mode.
Elm scroller for example took that function overwrote it and did onyl
permit logical registrations. Then again a evaluation of the focus state
and flags took place, and the function considered elm_scroller should be
registered as regular object, but found it to be logical. This lead to
the problem that we permantently unregistered Elm.Scroller and
registered it again as logical just to unregister it again. This was on
the one side a performance downside. But also a bug since all items from
within the Elm_Scrollers sub manager are getting reparent onto the
parent, which means not the root of the scroller (the scroller itself)
is the logical entrypoint to the widget but rather this reparented
widget, which led to unexpected focus warps like described in T5923.
tldr: this fixes T5923
|
|
|
|
|
| |
with this and the backtrace you can probebly figure out if you just
registered the same widget twice for different types
|
| |
|
| |
|
|
|
|
| |
a widget in higher hirachies is not registered in the lower one.
|
|
|
|
|
| |
if we have been redirecting before, we would have lost that event due to
the element here beeing at the top of that focus stack
|
|
|
|
|
| |
This just brings the functionality, the manager that is used as sub can
still be decided and be brought in via inheritance or compositition
|
|
|
|
|
|
|
|
| |
dont delete the obj during finalize... just retyurn NULL to fail.
fork() failed for me so i found this... ask not why fork failed... but
it did... and thus found this error handling case.
@fix
|
|
|
|
|
|
| |
enlightenment internal windows insta segv e on rpi. after much hunting
it seems a fallback is happening and bunk ptrs are being used. this at
least will make the problems more reliable with null ptrs.
|
|
|
|
|
|
| |
Turns out the "device_open" function pretty much just tests calloc
functionality, and doesn't open any device. So let's allocate a
tiny bo and discard it to make sure we're actually on exynos.
|
|
|
|
| |
The engage feature was mainly there as a demo of the capabilities of bryce. Now that we are nearing release we need to clean up our gadgets. The engage style for the luncher gadget is not complete, and does not work adequately, and quite honestly better belongs as a feature of bryce itself not luncher.
|
|
|
|
|
|
|
|
|
| |
We needed to do this to prevent burning cpu with animated cursors
before we did frame callback based animating.
Now the compositor will stop our frame callbacks when our cursor
is implicitly visible when the pointer isn't over our window,
so we don't have to use window hides for it.
|
|
|
|
|
|
| |
broken in 0516cdc0f9dc0969ac96df6984af2413680cad01
@fix
|
|
|
|
|
|
|
|
| |
a canvas can have multiple objects with the same name. assuming that name:obj
is a 1:1 ratio means that name-finding functions are likely to return invalid
objects
@fix
|
|
|
|
| |
We don't want to do frame callbacks until after we can actually draw stuff
|
| |
|
|
|
|
|
| |
Some distros are sitting at 1.9 for a long time now, and 1.10
didn't add any critical functionality for us.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Function argument was renamed, but in function body still uses old
variable name.
Test Plan: Build on Windows host
Reviewers: cedric, vtorri
Reviewed By: vtorri
Subscribers: jpeg
Tags: #windows, #efl
Differential Revision: https://phab.enlightenment.org/D5152
|
|
|
|
| |
Ref T5900
|
|
|
|
|
|
|
|
| |
An ugly const char * is returned from strdup, freed later with a custom
function that just calls free(). This was probably intended for
stringshare but now free is used. We have to fix the free function for
the EO API so let's keep free(). I'd rather avoid declaring
elm_config_profile_dir_free in the EO files.
|
| |
|
|
|
|
|
|
|
|
| |
This makes the icon test actually work. Otherwise the icon data is too
big and basically seems ignored by the compositor or X.
Note: In E (X11) it seems that the window icon remains unchanged? xprop
shows the proper data, though. Ping @zmike.
|
|
|
|
|
|
|
|
| |
The EINA_MAGIC check inside eina_array were just printing the error
message, without failing. This could lead to more crashes than
necessary.
@fix
|
|
|
|
| |
Ref T5322
|
|
|
|
|
|
|
| |
The legacy API wraps the EO API.
All tested with "Configuration" test case in elm_test.
Ref T5322
|
|
|
|
|
|
|
|
| |
Note: The distinction is made on how the window was created, not on
which API is used (evas_object_lower or efl_gfx_stack_lower or
elm_win_lower).
Ref T5322
|
|
|
|
|
|
|
| |
I think the intercept is not required anymore. All raise functions call
the ecore evas raise function.
Ref T5322
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See the previous commits. All focus_highlight APIs are defined in the
Widget class but only implemented at the Window level. For consistency I
believe this call should also be forwarded to the window. The previous
logic had absolutely no effect at all, except storing a stringshare.
The day focus_highlight becomes widget-specific (i.e. each widget has
its own highlight style) then this can be changed.
Note: This will apply to legacy API as well.
Ref T5363
|
|
|
|
|
|
|
| |
Similar to the previous commits. Moved for consistency.
Ref T5363
Ref T5322
|
|
|
|
|
|
|
| |
This was actually declared in the internal legacy API in widget.
Forwards the calls to the window.
Ref T
|
|
|
|
|
|
|
|
|
| |
Note: elm_test "Focus Style" can be used to test this API. The test case
is a bit broken (overly complex EDC?) but if you're patient you can see
the difference between "glow" and "glow_effect".
Ref T5363
Ref T5322
|
|
|
|
|
|
|
| |
on_focus seems to imply that focus was just given to the widget, but
that function is called on any focus change (in and out).
Ref T5363
|
|
|
|
|
|
|
| |
I believe this should work fine!
Ref T5363
Ref T5322
|
|
|
|
| |
Thanks Sanghyeon for letting me know!
|
|
|
|
|
|
|
|
| |
I broke this in commit 1bb45f6e6194fa046d3d1409e1aacecc14dc4b4f
We intentionally *don't* flush in window_semi_free, as this could be
when there's no compositor left to flush to (in the case of session
recovery).
|
|
|
|
|
| |
With this patch we finally reached 100% doc coverage in EO files again.
It would be nice to keep it like this.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|