| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: strerror_r() does not exist on Windows, but strerror_s() does
Test Plan: compilation
Reviewers: cedric, bu5hm4n, zmike
Reviewed By: zmike
Subscribers: zmike, bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8279
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Coverity reports that we potentially leak the storage of
'tree_iterator' here because we allocate the space for it, but
potentially juse return due to use of ELM_WIDGET_DATA_GET_OR_RETURN.
To fix this, just move the allocation to after the above macro is
called.
Fixes Coverity CID1399088
@fix
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8314
|
|
|
|
|
|
|
|
|
|
|
|
| |
Small patch to check the return value of ecore_file_cp. Coverity
reports this as an unchecked return value, so let's just add a simple
check here.
Fixes Coverity CID1399101
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8309
|
|
|
|
|
|
|
|
|
|
|
| |
Small patch to fix a resource leak. Variable 'command' goes out of
scope here which causes a leak.
Fixes Coverity CID1399085
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8308
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Small patch to remove logically dead code. Coverity reports that
execution cannot reach the expression 0U inside this for statement. At
this point in execution, 'array' cannot be NULL, so checking for its
existence is a logically dead check.
Fixes Coverity CID1399106
@fix
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8306
|
|
|
|
|
|
|
|
| |
This reverts commit 649433560b5b6c81e2136d0e2d036042f035b00c.
This patch is reverted because this patch breaks the backward
compatibility.
Please check Popup in elementary_test.
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 0e027980f6c275f1a56ae550679010d689c91b23.
Since D7888 breaks the backward compatibility, D7888 is going to be
reverted. This patch is based on D7888 so this patch is also required to
be reverted for now.
After a proper patch is applied instead of D7888, then this patch can be
submitted again.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Small patch to fix a resource leak detected by Coverity. Coverity
reports that 'refls' going out of scope leaks the storage it points
to, so let's free it before we leave the function.
Fixes Coverity CID1399099
Depends on D8309
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: q66
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8310
|
|
|
|
|
|
|
| |
this is really, really stupid.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D8305
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Coverity reports that va_end is never called for p_list when we error
out of this function. This patch adds a missing va_end before we error
out of here.
Fixes Coverity CID1399080
@fix
Depends on D8315
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: q66
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8316
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: this was added by accident in D8244
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8304
|
|
|
|
|
| |
Since commit ceb4c04d3b8f8eb94d63174b7b6f43641ea508a8 the parts block in
efl.ui.widget is disabled which leads to compile errors of the example.
|
|
|
|
|
|
| |
Since commit 2a003420f83134331c8b404df1905cba538cfad6 we need
beta_class.eo for the eolain cxx test suite. I never was added to the
files for dist, thus breaking distcheck.
|
|
|
|
|
| |
Since Efl.Ui.Layout is renamed to Efl.Ui.Layout_Base, the bar value is
fixed to be Efl.Ui.Layout_Base.
|
|
|
|
|
|
|
|
|
| |
The following efl ui headers move from Elementary.h to Efl_Ui.h.
efl_ui_navigation_bar.eo.h
efl_ui_navigation_bar_part.eo.h
efl_ui_navigation_bar_part_back_button.eo.h
efl_ui_navigation_layout.eo.h
efl_ui_stack.eo.h
|
|
|
|
|
|
|
|
| |
Here is a replacement to use eina_file from a vg obj instance
to map file data by vg loaders.
This brings a benefit that integrated access to load data
between vg object and vg loaders.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
names like `focus_geometry,changed` shoud be converted to
FocusGeometryChanged instead of Focus_geometryChanged.
Fixes T7735
Test Plan: run tests
Reviewers: vitor.sousa, felipealmeida, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7735
Differential Revision: https://phab.enlightenment.org/D8301
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
render,post is just forwarding the legacy type which is not the best as it expose
internal structure directly. Planning to move to an accessor for after this release,
but at this time it does imply way to much change for this current release.
Depends on D8249
Reviewers: zmike, stefan_schmidt, segfaultxavi, bu5hm4n
Reviewed By: zmike, bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl_api, PHID-PROJ-55rnlag4d454jfmlmuhu
Maniphest Tasks: T7729
Differential Revision: https://phab.enlightenment.org/D8250
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Triggering legacy event call for non legacy event on a an object that is
also non legacy made little sense.
Reviewers: zmike, stefan_schmidt, segfaultxavi, bu5hm4n
Reviewed By: zmike, bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7729
Differential Revision: https://phab.enlightenment.org/D8249
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
those are the completly wrong properties, please be carefull with this.
There is a major difference between focus_geometry and geometry on the
entity. In a viewport for example its the viewport itself - the bars at
the side. Additionally, not every focus object is a efl.gfx.entity.
this fixes a giant amount of errors when you try to test terminology,
emixer, toolbar tests or something like this.
fixup 1d9fef8da6fb4f679113d9dc4f57f1520fd31936
Reviewers: cedric, segfaultxavi, zmike
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8300
|
|
|
|
|
|
|
| |
This only works with a new libcheck, but not with a old one, revisiting
it.
This reverts commit da0ff534716774b35a98c359e8c7fd7bdde7a3d2.
|
|
|
|
|
|
|
|
|
|
| |
the part is not stable, as the type is not stable. However, we lack the
support of declaring parts beta, so we just comment them out.
This can be reverted after the release.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8298
|
|
|
|
|
|
|
| |
fix T7731
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8296
|
|
|
|
|
|
|
|
|
|
| |
the adapter has no geometry, so we must use the object from the adapter data
ref D8287
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8295
|
|
|
|
|
|
|
| |
ref T7511
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8294
|
|
|
|
|
|
|
|
|
| |
be consistent with property name and '*,changed' event info convention
ref T7511
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8293
|
|
|
|
|
| |
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8292
|
|
|
|
|
|
|
| |
fixes distcheck
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8291
|
|
|
|
|
|
|
| |
ref T7562
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8290
|
|
|
|
|
|
|
|
|
|
| |
It seems that theme_apply in sub_object_add haven't worked since commit
f6fa1ef6120fdebcdaf1568674c48b9d17f76f64.
scale, theme property will be set properly when the parent is changed.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8283
|
|
|
|
|
|
|
|
|
|
|
|
| |
but rather use the sys_bsd flag. The reason why relying on the header
existance is bad, is that bsd decided to install this header, with the
essential difference, that on bsd we require to link against libinotify,
which makes the compilation fail.
ref T7710
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8093
|
|
|
|
|
|
|
|
|
|
| |
function
Add missing exception check code with unit test.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8282
|
|
|
|
|
|
|
| |
this was overseen and should be refactored.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8297
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
In order to work around an issue with Efl.App, which is stable but
inherits from Efl.Core.Command_Line, @beta interfaces/mixins in the
inheritance chain are simply skipped.
Also changed the class used int test for inheritance from C#
Efl.Loop is stable but internally it uses a @beta class as argument to
its Register() method in the constructor. When instantiating a
user-defined C# subclass, the binding calls the C# override in the
NativeInherit class and the marshalling fails as no code is generated
for the beta class.
Also moved Efl.Part test to a beta class. Efl.Part is still beta.
Regarding parts, they are skipped if its class is @beta too.
Also rejected all elm_* files in elm public eo files. They should get
back in as they are converted to Efl.Ui.* api. An exception is
elm_interface_scrollable.eo, as efl_ui_panel depends on it.
Fixes T7730
Test Plan: Run tests
Reviewers: vitor.sousa, segfaultxavi, felipealmeida, cedric, bu5hm4n, zmike
Reviewed By: vitor.sousa
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7730
Differential Revision: https://phab.enlightenment.org/D8268
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: Fixes T7732
Reviewers: cedric, felipealmeida, vitor.sousa, bu5hm4n
Reviewed By: vitor.sousa
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7732
Differential Revision: https://phab.enlightenment.org/D8267
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
- Changed beta methods guards from CLASS_NAME_GUARD to
EFL_BETA_API_SUPPORT to use the same scheme as C.
- Removed some includes to Efl_Ui.h from the examples. These were
causing C's efl_part_get to not be generated due to EFL_PART_PROTECTED
not being yet defined (it is defined in Elementary.hh, included
afterwards). This was leading to Efl.Part.impl.hh trying to use a
non-existent method.
Fixes T7716 partially (missing stringshare issue)
Test Plan: make examples
Reviewers: stefan_schmidt, felipealmeida, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7716
Differential Revision: https://phab.enlightenment.org/D8284
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8289
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
these types are not currently being released and eolian should not have
generated legacy code using them
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8288
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: ref T7571
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7571
Differential Revision: https://phab.enlightenment.org/D8287
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
This enables all the checks unconditionally, without ignoring
classes that don't have an Efl namespace. This required a lot
of beta marking to make it build. It most likely doesn't
mark types correctly, as that is not fully enabled yet.
Reviewers: zmike, cedric, segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8266
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi, bu5hm4n
Subscribers: bu5hm4n, kimcinoo, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8281
|
|
|
|
| |
vg_entry ptr can't gurantee that new setting file is loaded or not.
|
| |
|