| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
| |
@feature
|
| |
|
|
| |
prevent release of pre-existing buffers during a render cycle
|
| |
|
|
| |
this is still pretty broken for some directions, client-side aspect fml
|
| |
|
|
| |
fix display refcounting
|
| |
|
|
|
|
| |
ensure hinted size is used
@fix
|
| | |
|
| | |
|
| |
|
|
|
|
| |
also don't set arbitrary hints on init
@fix
|
| |
|
|
| |
@feature
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
@feature
|
| |
|
|
| |
I guess posting an oom error is security
|
| |
|
|
|
|
|
|
|
|
| |
As this function is not called from anywhere outside of
ecore_wl2_window.c file, this can be declared static.
NB: This patch also changes the function name to match the library
(ecore_wl2).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, elementary programs crash on termination on macOS (seems
Sierra-specific). This is very nasty, looks like deep memory corruption...
Without valgrind (or like) support on Sierra, it is difficult to
pinpoint the origin of the problem.
Due to the imminient release, and after discussion with @stefan, this
kludge will allow the release to happen.
This commit MUST be reverted just after the release, so we don't
blindfold ourselves!
Ref T5245
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
When a virtualized file is created the file->global_map will not
point to a mmapped region, thus it's not safe to use munmap() during
the file cleanup. Only use munmap() if the file is backed by a FD.
Fixes: T5234.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
In order to perform IO operations the copier will create futures using
efl_future_use(&pd->job, ...), which will set pd->job to NULL once the
future is destroyed. However this may lead to problems, because in some
cases the copier may be deleted at the _efl_io_copier_job() function,
which is the future's callback. Since the copier may be deleted before
the future, the area pointed by pd->job will have disappeared by the time the future
tries to set pd->job to NULL. To avoid this problem the copier must
explicily call efl_wref_del().
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
| |
|
|
|
|
| |
bad endian... code... see the comment in the src about why i think
this is bad as obviously the buffer pointed to is a 64bit type always
that is a pointer to something...
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
If user use the evas_object_smart_callback_add with no smart object,
it should be returned
@fix
Test Plan: self
Reviewers: jpeg, cedric, jypark
Differential Revision: https://phab.enlightenment.org/D5056
|
| |
|
|
|
|
|
| |
Forgot to remove that! It's better to disable for the release,
DBG() and XDBG() are disabled anyway.
CID 1308611
|
| |
|
|
|
|
| |
Add some safety checks.
CID 1374271
|
| |
|
|
|
|
| |
Recently introduced by @cedric
I think the name is not very clear, and is clashing with the
actual method of the same name.
|
| |
|
|
|
|
|
| |
8 bytes wasn't enough for the full int range. use 12 and we're good.
removes warning for sure
@fix
|
| |
|
|
|
| |
could potentially be an issue in one theoretical case. less warnings
is better anyway
|
| |
|
|
|
| |
keep our build quiet warnings-wise and change the code to be so... so
we see real warnings. not a bug... just a warning.
|
| | |
|
| |
|
|
|
|
|
| |
this should help with repdocucable builds by having our hamsters
constant for a build of a specific code revision.
@fix
|
| |
|
|
|
|
| |
didnt detect cflags properly. now it does.
@fix
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This happens in E with software compositing, since E's commit
5702f0975e890f07cfb. E should be fixed shortly but segv is not
acceptable. Without segv E is still massively broken so it's
not like the bug would be hidden (large black areas in windows,
after switch vdesks with enough windows).
|
| | |
|
| |
|
|
|
|
|
| |
This reverts commit 936ea58cb9ac3e93aaabb6ec731fc3845cf95826.
this is an ideal change, but it breaks previously-expected behaviors
for interceptors and thus enlightenment is completely broken
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it turns out that xlib is going to copy the complete struct into
something internal. This might lead to the condition that a uninitalized
value might be part of the struct, and when later the struct is read
again the code might do wrong stuff since that value could be set now to
a randomly other meaningfull value.
This turned out on me in e as i could not write any letters like ßöäü,
since that lead to a not returning call to _XReply internal of xlib.
Dugging that showed that xlib was waiting on a reply of a call that
never got executed, and the XEvent it is waiting on just contians a
randomly correct value.
@fix
|
| |
|
|
|
|
|
|
|
| |
This amends 8e311db414950e399099acc1c0a as the logic
was badly broken. A "shadow" variable warning
clearly showed that "tmp" was not used properly.
This fixes the "IBM" logo in svg-test (the only one
using polygon/polyline, it seems).
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 2d4d836018387470b5df2c59119ab6cc81188e94.
Don't pretend to fix an issue found by a static analyzer by
introducing another issue that even clang warns about.
Fixes:
elm_gesture_layer.c:2533: warning: using floating point absolute value
function 'fabs' when argument is of integer type [-Wabsolute-value]
if ((fabs(st->info.mx) > ELM_GESTURE_MINIMUM_MOMENTUM) ||
^
|
| |
|
|
|
|
| |
The elm_access a widget makes primitive object accessible. If a primitive
object is not visible, then the elm_access should NOT have state VISIBLE, and
SHOWING. From now the elm_access is checking visibility of primitive object.
|
| |
|
|
| |
better to keep the func local unless needed elsewhere too
|
| |
|
|
| |
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
|
| |
|
|
|
| |
We were doing this so E could do screenshots in a hackish way,
E has been fixed so this hack here no longer needs to live.
|
| |
|
|
|
| |
When I added the fallback block I left an if statement that could
never evaluate to true. Remove it.
|
| |
|
|
| |
Stop leaking the render node fd to child processes.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Whatever the dbus_connection_send_with_reply returns, the serial value
should be checked, because if the seral value is invalid a process could be aborted.
There is backtrace as below.
The dbus_connection_send_with_reply could return TRUE
even though it has a problem. Please refer to following comment:
/* Refuse to send fds on a connection that cannot handle
them. Unfortunately we cannot return a proper error here, so
the best we can do is return TRUE but leave *pending_return
as NULL. */
Test Plan:
There is not a exact reproduce step. If the Tizen login manager is relaunched
repeatedly, then the dbus and other service processes are relaunched.
If a service process tries to use dbus when the dbus has problem as above,
then it could be possilbe to get above backtrace.
Reviewers: raster, zehortigoza
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5053
@fix
|
| |
|
|
|
| |
elm_win_socket_listen api only work for EFL_UI_WIN_SOCKET_IMAGE type window.
So it is better to add type check code.
|
| |
|
|
| |
this fixes a whole bunch of warnings that just recently turned up...
|
| |
|
|
|
|
|
|
| |
the data was never returned! fix fix fix.
found by PVS studio
@fix
|
