| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
@feature
|
| |
|
|
| |
@fix
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
preview better.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
???????????????????????????????????????????????????????????????????????????????
@fix
|
| |
|
|
|
|
|
|
|
|
|
| |
If an object still has a parent inside the del intercept, we shouldn't
reset the "parent_sunk" flag. This would indeed break logic as
parent_sunk == false implies that a parent was never set, which means
the parent must be null. Right now this case isn't used but it can be
imagined with caches of evas objects (they should remain parented to
their evas).
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
efl_data_scope_safe_get() is often used to assert that an object is of a
certain type, but assuming it may be NULL or not of the required type.
This means that encountering an invalid type is an error handled by the
caller (we return NULL), and shouldn't print out extra ERR() logs.
This fixes issues with E run under eo_debug. E's code was safe as it's
using evas_object_smart_data_get() and verifies whether the returned
value is NULL (which is expected for a rectangle, for instance).
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
After the previous patch, the caller of efl_input_dup() clearly owns the
reference on the returned object, which means she must absolutely delete
or unref if manually.
Note that the previous patch changed the bug from use of invalid eo
pointer to leaking of objects. But the only way to support bindings with
something like dup() is to ensure we give a ref to the caller, and thus
the parent should be null.
Note: eo_debug was used extensively to reach this point.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This solves issues with efl_input_dup() which didn't properly give a
reference to the caller, resulting in dangling eo ids.
Note: This may trigger leaks (instead of invalid refs), but this now
actually reflects the meaning of @owned. This should work with bindings
and C API users should know to call efl_unref().
This patch is the reason for the previous improvements on eo_debug.
@fix
|
| | |
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
| |
After ecore_shutdown the main loop is dead, so the flag do_quit can be
safely reset to 0. This will fix issues with cycles of
elm_init/shutdown. This fixes:
CK_FORK=no tests/elementary/elm_suite elm_win
This patch relies on a few of the previous patches which ensure that
ecore is well shut down.
@fix
|
| |
|
|
|
|
| |
Ugly implementation but this will do.
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not enough to check the init generation count, if the cache data is
not reset properly.
This patch adds safety in two ways:
1. Actually reset the op call cache when we detect a new generation
2. Verify that we don't return NULL function pointer
The 1st point is absolutely necessary, 2nd is optional (extra cost of
one if()).
@fix
|
| |
|
|
|
|
| |
An old comment mentioned that this was explicitely not unregistered, but
I believe the comment isn't valid since ecore_event_type_flush() was
introduced.
|
| |
|
|
|
|
|
| |
ecore could not shut down properly in an elm_init()/elm_shutdown()
cycle, with 7 remaining references, all because of a typo.
This should help @cedric as well
|
| |
|
|
|
|
|
| |
This avoids calling:
ecore_evas_callback_delete_request_set
ecore_evas_callback_resize_set
twice when deleting a window. Also adds safety over sd->ee.
|
| |
|
|
|
|
|
|
|
|
| |
The incomplete reset (array to NULL but max not reset) triggers errors
in evas_thread_queue_append() where eina_inarray_grow() returns NULL.
This shows up in:
CK_FORK=no elm_suite
@fix
|
| |
|
|
|
|
|
|
|
| |
This should fix some errors in make check with CK_FORK=no
Test:
<efl/build>/src$ CK_FORK=no ./tests/elementary/elm_suite elm_config
@fix
|
| |
|
|
| |
This is an error happening in make check. Annoying but mostly harmless.
|
| |
|
|
|
|
|
|
| |
Somehow I was seeing a ton of errors with "prefs_iface" not found in
make check. This code could not have worked since the merge of
elementary in EFL tree...
@fix
|
| |
|
|
|
|
|
| |
in some cases loading an xmodmap on enlightenment startup can trigger an infinite
number of identical events which hard locks the xserver for a very, very long time
@fix
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Test scenario:
- elementary_test -to "ExtProgressBar"
- Then click on "... from C
Fixes T6032
@fix
|
| | |
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
|
|
|
|
| |
Summary:
The code in eina_debug.c requires the eina_swapX() functions on big endian platforms, so include the required header.
Test Plan: Do build on big endian platform like ppc64 or s390x.
Subscribers: kubu, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5158
|
| |
|
|
|
|
|
|
|
| |
for both ecore_exe_win32.c and ecore_exe_posix.c when the rare case
(basically almost never) that malloc fails for the exe read/err
buffers also set the data size to 0 so it doesn't lie with a NULL ptr
for data.
@fix
|
| |
|
|
| |
T6029
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
device adds can happen late, which means evas does not know the default
device until a time that is later than the focusing of some edje part.
Which means that keystrokes etc. are lost for the parts beeing focused
before the default device appeared. This should fix that.
For the later people in this world: Watch out! someone decided to map
seats in edje with a linear counter starting at 1, which means
seat0<->seat1 seat1<->seat2 thanks for that riddle, i feel like i have
beaten the sphinxs.
fix T6022
|
| |
|
|
|
|
|
|
|
|
| |
This affects:
- edje_object_part_swallow
- edje_object_part_swallow_get
Fixes T5944
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a problem with the previous version. The object can still be
alive due to the use of manual_free in evas. So you wouldn't be able
for example to remove a callback from an object that hasn't been
destroyed yet. If that callback is triggered by the destruction
of the object, you would end up with an unexpected and impossible to
prevent effect of access after free on a callback that you had removed.
Not sure if that still solve the original problem that the code was
trying to prevent in Ecore_Evas.
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Fixes T5968
@fix
|
| |
|
|
|
|
|
|
|
| |
This is an attempt at fixing crashes in empc.
Test scenario:
ELM_ACCEL="" elementary_test -to "Gfx Filters"
And mouse scroll like crazy in the spinner.
@fix
|
| |
|
|
|
|
|
|
| |
Well... that's just embarassing... semaphore_destroy() actually takes
the mach task as its first parameter, not the second. This core
amazingly worked very fine on macOS earlier than Sierra.
Fixes T5245
|
| |
|
|
|
| |
This reverts commit 9368eedd353a88dd31ba50c71433f81a2978adb5.
A proper fix has been found!
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
When harfbuzz is enabled, _content_create_ot() function will be used
for shaping. If evas_common_font_int_cache_glyph_get() failed in some reason,
it never proceed gl_itr until the end.
It can cause weird rendering result. Because, all of gl_itr after the failure
can't have proper x_bear, y_bear and width.
@fix
Test Plan: N/A
Reviewers: raster, cedric, herdsman, jpeg
Differential Revision: https://phab.enlightenment.org/D5154
|
| |
|
|
| |
The engage feature was mainly there as a demo of the capabilities of bryce. Now that we are nearing release we need to clean up our gadgets. The engage style for the luncher gadget is not complete, and does not work adequately, and quite honestly better belongs as a feature of bryce itself not luncher.
|
| |
|
|
|
|
| |
broken in 0516cdc0f9dc0969ac96df6984af2413680cad01
@fix
|
| |
|
|
|
|
|
|
| |
a canvas can have multiple objects with the same name. assuming that name:obj
is a 1:1 ratio means that name-finding functions are likely to return invalid
objects
@fix
|
| | |
|
| |
|
|
| |
This reverts commit 92735ad44e5b75085c35f4c088e8521868118602.
|
| |
|
|
|
|
| |
this should fix T5800
@fix
|
| | |
|
| |
|
|
|
|
| |
This reverts commit 02115a35e47df8c01823e6b59876f30bd90e19bb.
dont put this in stable
|
