summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* build test fixupdevs/stefan/ci-testStefan Schmidt2019-09-231-0/+3
|
* ci: add back target to do out-of-tree test buildMike Blumenkrantz2019-09-236-7/+75
| | | | | | | | this is necessary in order to ensure that our headers are usable ref T8228 Differential Revision: https://phab.enlightenment.org/D10036
* eina_log: do not fallback to INFO when we run with systemd supportMarcel Hollerbach2019-09-231-4/+0
| | | | | | | | | | INFO is a way too verbose log domain, this lead to the fact that we spammed journald before the first frame with ~200-300 messages (depending on the setup) which is quite a lot. Additionally, this also lead to the fact that we often TIMEOUT our own tests. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10075
* elementary_codegen: check before use to avoid use after freeStefan Schmidt2019-09-231-0/+4
| | | | | | | | | | | These might or might not have been freed already, depending on the breaks form the above loop. Before we are having a use after free here better check on it before free'ing another time. Coverity IDs: 1402671, 1402701 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10047
* efl_ui_exact_model: fix always true conditionStefan Schmidt2019-09-231-2/+3
| | | | | | | | | The tbuf binbuffer has already been freed the line above, which means this condition would always be true as !tbuf would always result in true. As a result the rest of the function has never been executed. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10046
* efl_ui_selection_manager: free allocated memory after local useStefan Schmidt2019-09-231-0/+1
| | | | | | | | | | This temporary allocation is only used in this block and goes out of scope when leaving. Make sure we free the resource before this happens. Coverity ID: 1402653 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10045
* efl_ui_textpath: make sure variables are not uses uninitializedStefan Schmidt2019-09-231-1/+2
| | | | | | | | | | First and last could have been uninitialized for their first use in some cases. Make sure we set the x y coordinates to 0 to begin with. Coverity IDs: 1401458, 1404747 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10044
* efl_ui_scrollable: remove ui_scrollable_interactive and move all into ↵WooHyun Jung2019-09-2317-218/+211
| | | | | | | | | | | | | | | | | | | | | | | ui_scrollable Summary: Based on the discussion T7883, there is no reason to keep those interfaces separately. So, now, efl_ui_scrollable will support the events and methods together. @ref T7883 Reviewers: eagleeye, bu5hm4n, zmike, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T7883 Differential Revision: https://phab.enlightenment.org/D10072
* test: Add a logic to check a size of CheckWonki Kim2019-09-232-0/+31
| | | | | | | | | | If I pack a check without any api calls into a box, then it doesn't have the hint_min size which is defined on check edc. I guess there are problems on sizing logic currently, so this patch helps people to test the problem. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10038
* elm/layout: remove check for finalize in efl_canvas_group_change implMike Blumenkrantz2019-09-231-1/+0
| | | | | | | | | | this used to be a thing in order to prevent widgets from spamming themselves with recalcs during construction, but since that's no longer possible we can remove this and also resolve an issue where legacy widgets failed to correctly calculate their min size if no text was set Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10043
* Use EFL version for doc tarball, not meson versionRoss Vandegrift2019-09-231-2/+2
| | | | | Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10070
* docs: Typos in Efl.ObjectXavi Artigas2019-09-231-2/+2
|
* efl_ui : fix possible memory leak on model compressingSangHyeon Jade Lee2019-09-231-2/+11
| | | | | | | | | | | | | | Summary: fix memory leak of model compressing on binbuf and allocated data. Reviewers: cedric, bu5hm4n, zmike Reviewed By: cedric, zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10037
* efl_ui_collection: protect against invalid accessMarcel Hollerbach2019-09-211-1/+2
| | | | | | | | i am not sure why this should ever happen. However, a error here is better than a access out of the bounds of the array. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10066
* efl_ui_bg: implement load_controller and efl.gfx.image via compositionMarcel Hollerbach2019-09-212-27/+4
| | | | | | | | | | With this commit the API of load controller and efl.gfx.image is implemented via composition, which makes eolians API checker happy ref T7880 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10064
* efl_gfx_image: remove ptr()Marcel Hollerbach2019-09-211-2/+2
| | | | | | | this is not needed here, and not permitted in a none beta context. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10069
* efl_ui_image: implement Efl.Gfx.Image and Efl.Gfx.Image_Load_ControllerMarcel Hollerbach2019-09-212-0/+252
| | | | | | | | | | | | | | | at first i tried to implement that with composition, however, this does not work, caused by the fact that the edje_object does not implement efl.gfx.image nor load controller. which would mean i would have to differentiate based on the type what kind of composition i would attach, additionally, i would have to write an additional object which would implement the correct behaviour. To shortcut this overdone approach, this commit simply implements the APIs in the image object. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10068
* elementary: make our tests work againMarcel Hollerbach2019-09-211-4/+6
| | | | | | | | | | 73219114682f64fdbfe0809be3f2d991016dd3f1 moved the constructor to to top, which leads to the fact that a few widgets cannot fetch the shared data of the window. Which made the test suite fail. With this commit we are just moving the sub_object_add after the constructor, which fixes the flip crash. This fixes the test suite
* efl ui widget - call parent constructor before doing more initCarsten Haitzler (Rasterman)2019-09-211-2/+2
| | | | | | | | | | | the object is not properly set up yet for child classes -0 parent like the main evas object or smart obj havent been constructed yet so call this really early, not in the middle of construction of an efl ui widget... this fixes a segv in elementary_test -to filp where it segv's on object construction where evas object ->cur/prev are NULL (not set up yet).
* csharp: Guard hash usage behind EFL_BETA.Lauro Moura2019-09-205-52/+63
| | | | | | | | | | | | | | Summary: After 718f3cd49586, hashes are currently beta-only. Reviewers: zmike, brunobelo Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10060
* eolian_mono: add more verbs to generate C# method beginning with verbJaehyun Cho2019-09-203-5/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary: C# language binding generates C# method name beginning with verb by checking verb list in name_helpers.hh. Some verbs used in eo method are missing in the current verb list. So they are added into the verb list. In this scheme, there is a problem that some words can be used as a verb in some methods but they also can be used as a noun in other methods. (e.g. drag_start as a verb / cursor_word_start as a noun) So "start" and "scroll" are not added to verb list in this patch. To resolve the above problem, we may need a new eo syntax to rename or reverse the name in language bindings. Test Plan: Check C# method names in .eo.cs files if the name begins with verb. Reviewers: felipealmeida, SanghyeonLee, woohyun, Jaehyun_Cho, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10001
* eolian: rename any_value_ptr -> any_value_ref for consistencyDaniel Kolesa2019-09-2022-50/+50
|
* eolian: string(share) is always const, allow in events out of boxDaniel Kolesa2019-09-201-4/+11
|
* eolian: make hashes beta-only for nowDaniel Kolesa2019-09-203-5/+10
| | | | | | | They're not completely settled on and we don't even know if we want them at all. So let's make them beta only for now. Ref T8050.
* Use proper Eolian syntax for default values instead of docsXavi Artigas2019-09-2010-77/+58
| | | | | | | | | | | | | | | | | | | | | | Summary: Eolian supports reporting the defaults for parameters and return values, but in some places we have been writing this information in the documentation instead. This patch moves it to its proper place, where documentation generators can pick it up and render it in a consistent manner. Ref T8171 Reviewers: zmike, bu5hm4n, lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8171 Differential Revision: https://phab.enlightenment.org/D10051
* csharp: Add support for default param references in documentationLauro Moura2019-09-203-24/+122
| | | | | | | | | | | | | | | | | | | | | | | Summary: This also adds the information of default values in `parameter_def`. This will help adding actual default parameter support in the C# bindings. Thanks to @segfaultxavi for improved formatting and escaping. Fixes T8224 Reviewers: segfaultxavi, felipealmeida, brunobelo Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, segfaultxavi, #committers Tags: #efl Maniphest Tasks: T8224 Differential Revision: https://phab.enlightenment.org/D10050
* efl_ui_factory: improve docsMarcel Hollerbach2019-09-202-8/+13
| | | | | | | | | | | | | | | | Summary: and remove TAAABS Depends on D10038 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10042
* efl.ui.scrollbar: fix event name for scrollbarHosang Kim2019-09-204-21/+21
| | | | | | | | | | | | | | Summary: Event name is applied in the past tense. Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10040
* build: switch build type to release for nowStefan Schmidt2019-09-201-1/+1
| | | | | | This should have been done with the first alpha, but there was a bug preventing this. With commit 6960751c4580af9e902cd7719c1acafab4ce7bc5 the problem is fixed and we can finally enable it.
* efl_ui_scroll_util: add null check after callocWooHyun Jung2019-09-201-0/+1
|
* efl_io_model: next try to fix this race conditionMarcel Hollerbach2019-09-199-1/+88
| | | | | | | | | | | | | | | | | | | what is happening is that a file gets announced through eio_model listing code, at this point of time, the monitor does not yet know about the file. If the file now gets deleted between the annoncing and the learning of the file from the monitor, then the file got an ADD event, but no DEL event. Which is a bug. With this commit there is a new API which asks the monitor if the file already has the knowledge about the files existance, or not. A few monitors like win32 inotify or cocoa do not have context about the file directly, if the OS is now having the same bug, then we are again in trouble, however, we canot do anything about that. In the case of kevent or poll, this asks the context of the monitor if the file is already there. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10006
* elementary: Efl.Ui.Widget_Factory bind widget property before finalizing the ↵Cedric BAIL2019-09-191-24/+22
| | | | | | | | | | widget. In the same vain as previous patch this will initialize more of the widget during its creation and reduce unecessary recalc. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9949
* elementary: leverage sizing information from model if available to avoid ↵Cedric BAIL2019-09-191-1/+18
| | | | | | | | | | unecessary calc. With the new Efl unified infrastructure, we do delay a lot of the computation to finalize, by filling the object information before finalize we reduce unecessary computation. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9948
* efl_ui_position_manager: a way to announce new entitiesMarcel Hollerbach2019-09-195-0/+85
| | | | | | | | | there are situations where the entity is not ready yet when the initial placing does happen. With this API you can tell the position manager that the placing of the items can be reapplied at the entities are availble now. Differential Revision: https://phab.enlightenment.org/D9947
* efl: improve Efl.Boolean_Model test to enforce Eina_Value type too.Cedric Bail2019-09-191-4/+4
| | | | | Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10031
* ecore: remove unused piece of code.Cedric Bail2019-09-193-140/+0
| | | | | Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10030
* ecore: properly initialize all field in event generated by Efl.Generic_ModelCedric Bail2019-09-191-1/+1
| | | | | Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10029
* ecore: properly initialize the event structure in Efl.Generic_Model.Cedric Bail2019-09-191-1/+1
| | | | | Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10028
* eina: add code to help debug leaking Eina_Value.Cedric Bail2019-09-191-0/+41
| | | | | Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9942
* eina: add eina_mempool_iterator_new to slowly iterate every allocated ↵Cedric Bail2019-09-197-13/+209
| | | | | | | pointer in a mempool. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9941
* efl_ui_layout_part_table: implement missing APIMarcel Hollerbach2019-09-192-3/+21
| | | | | | | | setting of these properties does not work, as they are not available in legacy, but edje is still creating legacy objects. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10007
* efl_ui_layout_part_*: declare stableMarcel Hollerbach2019-09-196-6/+6
| | | | | Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D9995
* efl_ui_widget_*: declare parts stableMarcel Hollerbach2019-09-194-5/+5
| | | | | Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D9994
* efl_ui_layout_part_box/table: remove real_part_setMarcel Hollerbach2019-09-193-38/+11
| | | | | | | | | | real part set was used to set the real part on the part, so the obj pointer of Layout_Part_Data points to the correct evas object. With this commit, this API is removed from the public .eo files, and is refactored into the same API which is private. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9993
* efl_ui_layout_part_table: implement Efl.Pack.pack APIMarcel Hollerbach2019-09-192-0/+43
| | | | | | | | this api was missing, the pack method here is behaving in the same manner as Efl.Ui.Table. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D9992
* efl_ui_widget_part: implement all the missing APIMarcel Hollerbach2019-09-192-12/+7
| | | | | | | | | Efl.Color and Efl.File cannot be done due to composition. Efl.Gfx.Image can, so we can solve this via composition, this also resolves all the other cases for Efl.Gfx.Image. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9991
* efl_test_multi_selectable: test for the correct eventMarcel Hollerbach2019-09-191-23/+9
| | | | | | | | | | EFL_UI_EVENT_ITEM_SELECTED / UNSELECTED is the wrong event here. We should check of the selection changed event. ITEM_SELECTED is the legacy event. this was not found based on the fact that we test for this event to NOT be executed. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10011
* elm_test_widget_focus: cleanup callbacks correctlyMarcel Hollerbach2019-09-191-0/+2
| | | | | | | | | | | | | we need to delete the callback here, otherwise the objects are deleted later on, which: - changes focus, which leads to - callbacks executed with stacked addresses from a dead function this fixes a testsuite failure on the release build. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10020
* efl_ui_collection: fix null pointer dereferencesYeongjong Lee2019-09-191-0/+1
| | | | | | | This will fix Coverity issue. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9986
* eo: custom created legacy events should be unfreezableMarcel Hollerbach2019-09-191-0/+1
| | | | | | | | | | | | | a while back we have moved event submission from custom lists to eo events. We also merged together the freeze and thaw functions, however, this brought up one bug. smart_callbacks and the likes (those that used custom lists before) are not effected by the legacy freeze and thaw functions. This means, we should declare these legacy wrapper objects unfreezable in order to obtain this behaviour. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com> Differential Revision: https://phab.enlightenment.org/D10016