| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
collectionview item layouts no longer recalc. ever.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The idea of this widget is to provide to MVVM what Efl.Ui.Collection provide and
leverage the same shared logic for layout.
|
|
|
|
|
|
| |
constructing is called during construction time, building is called
after finalize. This is usefull for theme related properties that can
only be set after the theme is applied, which happens during finalize.
|
|
|
|
|
| |
In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.
|
|
|
|
|
| |
In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.
|
|
|
|
|
|
|
| |
widget.
In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.
|
|
|
|
|
|
|
| |
unecessary calc.
With the new Efl unified infrastructure, we do delay a lot of the computation to finalize,
by filling the object information before finalize we reduce unecessary computation.
|
|
|
|
|
|
| |
its sometimes possible that there is a NULL object returned by the batch
call. We should not just access the NULL element. Additionally, if NULL
was returned during visibility setting, we need to set visibility here.
|
|
|
|
|
|
|
|
| |
we are walking all the items anyways, so we can recalc the minsize here
anyways. Additionally, this pm was never tested with code that just
passes a set of items at data-access init time, without calling
item_added for each item. (Which is perfectly fine). With this commit
this is now perfectly possible,
|
|
|
|
|
|
|
| |
if we are not finalized yet, there is no reason to calculate the caches,
as this will be redone later on anyways.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
|
|
|
|
|
|
| |
this can be skipped.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
|
|
|
|
|
| |
the cache need to be required here, as we are going to access it later
on.
|
|
|
|
|
|
|
|
|
|
| |
it is possible that the object returned by the batching call is NULL.
That is valid, however, if the batching call for the visibility is
getting the NULL element, but the placement is getting the none NULL
element, then the item on screen will not be visible. This commit
ensures that those items will be visible.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
|
|
|
|
|
|
|
|
| |
when sizes are different to the cached size, then the displayed items
are out of order, or do not fill the whole viewport. This should not
happen. In case that this is detected, print an error.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after playing arround with the widget, we found out that it feels quite
weird to have a index, where most of the time you work with widgets.
We might want to add syntax suger in the future to make it easier to
just jump to the next element, or to the previous, but that still is to
be decided.
The event and the communication to the spotlight manager are still left
to be used with the index, reason for this is, that we might need to
fill there an invalid pointer, if a deletion is triggering an animation,
which seems quite weird. That needs further discussing.
Docx have been updated, the sitemarks about the shifting of the
active_index can be removed, as the element is not subject of change
during content adds/deletes.
ref T7991
Differential Revision: https://phab.enlightenment.org/D9813
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This complements the equivalent APIs of parameters and so on.
It is not the same as the older type_is_owned API, which applied
to everything.
|
|
|
|
|
|
|
| |
This refactors ownability checks so that they're only performed
in contexts where @move can be specified, which both helps
with performance and enables later removal of ownability info
from types themselves.
|
|
|
|
|
| |
The @by_ref qualifier can only be used with value types, to
guarantee exactly one level of pointers.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: Popup api changed in 1ca07b72da944
Reviewers: zmike, felipealmeida, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9807
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
the group hirachy that you can build up with group items is flattend
down in the collection, as a linear list. Based on that a user might be
able to insert items at invalid positions, like between groups, without
having set the proper group item, which ... is a problem.
This commit ensures that no new item ever destroys the neightboor hood
between two items of the same group or a item with a group and its group
leader.
Reviewers: stefan_schmidt, zmike, segfaultxavi, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9778
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
this is just a duplicate of entity geometry changed events, users of
pan should just use those instead
ref T7708
Depends on D9791
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7708
Differential Revision: https://phab.enlightenment.org/D9792
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
changing the size of the pan content does not require that the pan
position also changes, so let users of pan sort this out using the correct
events
ref T7708
Depends on D9790
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7708
Differential Revision: https://phab.enlightenment.org/D9791
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
changed events should always send the related data when possible
ref T7708
Depends on D9789
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7708
Differential Revision: https://phab.enlightenment.org/D9790
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
this is a shortcut so pan users don't have to manually hook the content
resize event
Depends on D9788
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D9789
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
the pan object is not changing its position, it's moving the content
ref T7708
Depends on D9787
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7708
Differential Revision: https://phab.enlightenment.org/D9788
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
this was being emitted as a catch-all for pan changes, where something else
should have been monitored/used instead
ref T7708
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7708
Differential Revision: https://phab.enlightenment.org/D9787
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
This is detected by static analysis tool.
The variable last could be NULL when it is dereferenced.
Reviewers: Hermet, zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9796
|
|
|
|
|
|
|
| |
case left over that this didnt handle right and this breaks e's dnd
once a file preview popup appears.
@fix
|
|
|
|
|
|
|
| |
fixes a lot of compiler warnings
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9802
|
|
|
|
|
|
|
|
|
| |
simple property rename
ref T7902
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9801
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl, #documentation
Differential Revision: https://phab.enlightenment.org/D9798
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The @by_ref qualifier is now allowed on parameters, returns and
struct fields in the usual qualifier section. It will mean that
this type is passed around by reference, and will only be allowed
on types that are not already pointer-like.
The @move qualifier will replace @owned as one with a clearer
meaning. It means "transfer of ownership". It has the same semantics
as the current @owned, i.e. on return values it transfers ownership
of the value to the caller, on parameters it transfers ownership
to the callee (the inverse is the default when not specified).
On struct fields, it means the field will transfer together with
the struct that contains it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: If current_text is NULL, a segmentation fault is occured.
Test Plan: N/A
Reviewers: cedric, Hermet, Jaehyun_Cho, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9780
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Without new internal min/max properties, this may be the only way
to not give redundant printing of the meaningless value.
@ref T8188
Test Plan:
1. elementary_test
2. EFl.Ui.Slider
3. On the limit slider, move the knob above the limit
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8188
Differential Revision: https://phab.enlightenment.org/D9793
|
|
|
|
|
|
|
|
| |
i saw a segv in e/efm .. an eio call was called after it had been
canceled. this should never happen. ever. so ensure it does not once
an eio file has been canceled.
@fix
|