| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
edje_object_part_text_cursor_prev/next/up/down has return value.
It has to return EINA_TRUE when only it successed.
But, when these funcs moved to legacy, it changed to return EINA_TRUE
whenever it fails or success. It must return EINA_FALSE when it fails.
@fix
Test Plan:
- Run test suite
make check
Reviewers: herdsman, raster, cedric, woohyun
Subscribers: zmike
Differential Revision: https://phab.enlightenment.org/D5972
Committer's note: backported with an additional fix to tests.
|
| |
|
|
|
|
|
|
| |
before c65782b15c0af7c25c5506cdf79cbbfa39604fec the acutal path has
been filled into buf, with eina_file_mkstemp the string is filled into
tmpstr, so that path should be chmoded instead of the template buf.
Thx to MatP for the report!
|
| |
|
|
|
| |
commit 4dee873a appears to have accidentally flipped a flag in
_evas_canvas_norender causing it to actually try to render.
|
| |
|
|
|
|
|
| |
On linux we can do this test without firing a SIGILL and trapping it,
if getauxval() is present.
ref T6711
|
| | |
|
| |
|
|
| |
Fixes issues with Windows and general unused method warnings
|
| |
|
|
|
| |
Change-Id: Id329b87167caa71aadd8ca454c50e9aaca275415
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
|
| |
|
|
| |
@fix
|
| |
|
|
|
| |
read: Allow non-EFL style indentation.
This is off by default but is switched on if you turn 'tabs insert spaces' off
|
| |
|
|
|
|
|
| |
This resolves all sorts of issues on FreeBSD and OpenBSD. Linux
and valgrind seems to not detect these mmap/munmap problems.
@fix T5949
|
| |
|
|
| |
Fixes a forced disconnect error.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
T6164
|
| |
|
|
|
|
|
|
|
|
|
| |
In-tree libeina.so library path is missing while running elua.
http://autobuild.buildroot.net/results/2bb/2bbe89694c206d764d51a5dd9c75bc4aa844e98d/build-end.log
@ref T6670
Cc: Daniel Kolesa <d.kolesa@samsung.com>
Signed-off-by: Daniel Kolesa <d.kolesa@osg.samsung.com>
|
| |
|
|
| |
This reverts commit eb44d1cb5aecec59d540812303d048eaa5dbd763.
|
| |
|
|
|
|
|
|
|
| |
tjhis should fix empty items which might have a null item string...
deal with it
fixes T6668
@fix
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Content will still shift at 100 but that should be less intrusive
|
| |
|
|
| |
Fixes T6444
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Added some guards to avoid redefinition of functions.
Partially fixes T5866, as there is still the question whether we should
test internal functions or not, as stated by jpeg in the comments.
Reviewers: vtorri, felipealmeida, jpeg, cedric
Reviewed By: cedric
Subscribers: jenkins, cedric
Maniphest Tasks: T5866
Differential Revision: https://phab.enlightenment.org/D5521
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Keep track of visibility and ensure the cursor can never be
filled when hidden. This should finally end any issue with the
cursor and visibility with the new focus system. Didn't see this
previously until working on Edi's bottom panes which caused redraw
on resize of the widgets.
@fix
|
| |
|
|
|
|
| |
The cursor isn't clipped so if we decide to hide the widget
this ensures the cursor also is hidden. This should not affect
any existing application using elm_code API.
|
| |
|
|
|
| |
This ensures the widget is clearer if the file has been cleared.
@fix T6185
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
9d2dcd92 requires elocation to build.
cxx examples still broken due to elm cleanup
Test Plan: make examples
Reviewers: jpeg, felipealmeida
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5426
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
luajit wants to check the upper 17 bits of pointers and assume they
are all 0 if on a 64bit architecture. it will panic and barf if they
are used. we have been using them in our eoid's for a long time.
my take on this is that this is unportable. assuming how many bits are
or are not valid in an opaque pointer (void *) that is simply passed
to you and you cannot dereference or use (no size information even for
what amount of data it points to etc.), is just wrong. it's not
portable and it's trying to be too smart and creating such issues. my
take is that luajit needs a fix for this in the longer term. but for
now let's have a 47 bit mode and go with that. it does mean i have to
drop our generation counter to 10 bits on 64bit (from 27 bits) which
increases likelihood of eoid re-use being falsely detected as valid
(before on 64bit it was 1 in 130 million or so chance, with this 47
bit change it's 1 in 1000. but to be fair on 32bit it's 7 bits for gen
count so 1 in 127 ... so still more than 10x "safer" than on 32bit...
but still...). the relevant check in luajit is:
(((uint64_t)(p) >> 47) ? (lj_err_msg(L, LJ_ERR_BADLU), NULL) : (p))
it ONLY does this on 64bit. on 32bit pointers are not checked for
validity at all.
as an aside, armv8.2 seemingly will bring 52bit addresses so luajit is
going to fall over flat on a newer rev of armv8. it may be x86 also
uses more bits. last i knew it was 48bits so the 47 bit check luajit
does i think is even wrong for x86-64. to be detailed i read:
amd64 arch == 48 bits (so luajit is wrong). even better In addition,
the AMD specification requires that the most significant 16 bits of
any virtual address, bits 48 through 63, must be copies of bit 47 (in
a manner akin to sign extension). so if the upper bit of 48 is set
THEN all the 16 upper bits must be 1... breaking luajit, even if it
were 47bit and this rule applied. I read the architecture allows for
up to 52bits of actual addresses so architecture-wise this is even
wrong...
So I smell a core bug here in luajit. Certainly in the number of bits
it insists must be 0 (the upper 17 bits where on amd64/x86-64 it
should be the upper 16 bits... and even then these may NOT be 0 if bit
47 (the upper bit of the lower 48 is 1).... so the whole check is
invalid... :(
at least the above is at a theoretical level. i believe that the
addresses divide the 48 bits into 2 chunks (thus 47)... but at the
PHYSICAL level with no mmu and virtual memory. arm64 has this:
https://www.kernel.org/doc/Documentation/arm64/memory.txt
note in all cases the 2nd chunk of memory has at leats some upper bits
of physical addresses beign 1 ... which makes luajit invalid tyo use
without virtual memory remapping these away from high bits.
@fix
|
| |
|
|
|
|
|
| |
dragable values were invalid (not fetched) so vx/y were junk and this
was making decisions based on that. guarantee it to be 0.
@fix
|
| |
|
|
|
|
|
|
|
| |
As the filename is now a stringshare, also make sure virtual
files use stringshares for the filename! Also when unmapping
we still need to test whether it is copied or not as unmap
will break on less tolerant architectures.
@fix T6449
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Small patch to allow specifying a different seat via XDG_SEAT env
variable. If no seat name is passed as ecore_evas options, then we
would always default to 'seat0'. As this may not be desirable in all
situations, allow for an override via XDG_SEAT env var.
ref T6455
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
| |
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
| |
If we cannot create a new udev device, then we should free the
previously created udev enumeration from above.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
| |
As we do not ever use the udev_devices created from
udev_device_new_from_syspath in these functions, remove them.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
| |
if you ONLy unref it wont force an unparent if you never del'd.
@fix
|
| |
|
|
|
|
|
|
|
| |
Under some circumstances, eina crashes when attempting to display the
backtrace, because dladdr() may yield a dli_fname that is NULL. This is
especially annoying in realease, when the backtrace is shown by default
when CRI/ERR are thrown.
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
what i'm seeing is this with local unix sockets:
1. server process not cleanly shut down (kill -9 for example).
2. run server process again and bind fails due to EADDRINUSE
3. we ARE doing setsockopt() with SO_REUSEADDR set to 1 ...
this just makes no sense because setsockopt() SHOULD allow use to
re-use... the previous efreetd process for example is gone. no such
process, yet socket is not re-usable. this should just not happen due
to SO_REUSEADDR, but it does. this has nasty consequences like efreetd
maybe never running because of stale sockets. this should never have
happened, but it does. odd. so a hacky workaround:
1. try bind.
2. if bind fails with EADDRINUSE and its a socket path AND
pd->unlink_before_bind is NOT set... then try a connect to the socket.
3. if connect succeeds then fail as normal (close socket and error on
bind'ing)
if connect fails then we have a stale socket, so unlink it
forcibly. create the socket again and try bind again.
hacky but... fixes the core issue.
@fix
|
| | |
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
|
| |
ensure that this doesn't trigger xwayland deadlocks during gst init
probably fixes T6418
@fix
|
| |
|
|
|
|
|
|
|
|
|
| |
because as of... i don't know when, evas relies on ecore with
ecore_pipe_add to create the async fd... and if you init evas then
ecore this doesnt work. obviously. well now it isn't working. probably
due to new efl loop work. but the efl loop code is correct.
ecore_pipe_add should never work until you init ecore... it just
happesn to have managed to be gotten away with for a while.
@fix
|
| |
|
|
|
|
|
|
| |
so xine module plus 2 eina dbug threads didnt set up signal
blocking/masks correctly. xine use ssigprocmask not pthread_sigmask
and the other 2 didnt even bother at all. fix this so these threads
all block most of these commnly caught signals so these threads never
get them
|
| |
|
|
|
|
|
|
|
|
|
| |
Commit 9d583b3fdbed686642dbc0d96d1e417485ca0077 broke
ecore_drm2_output_enabled_set function due changing order of setting
output->enabled value. This patch fixes both issues by checking the
'enabled' variable being passed in.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
|
| |
If we are Not using Atomic/Hardware support for output rotations, we
should return all available rotations as these will still work in
software mode.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
