summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* release: Update NEWS and bump version for 1.22.6 releasev1.22.6efl-1.22devs/zmike/122citestMike Blumenkrantz2019-10-042-2/+15
|
* eolian-cxx: Release iteratorsLauro Moura2019-10-041-2/+8
| | | | | | | | | | | | | | | | | | | | Summary: When the iterators advanced, the CXX wrappers null'd them but did not call eina_value_free. ref T8280 Reviewers: q66, brunobelo, felipealmeida Reviewed By: q66 Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8280 Differential Revision: https://phab.enlightenment.org/D10238
* elm_code_widget: when the position is updated, set new geom to cursorMarcel Hollerbach2019-10-041-0/+3
| | | | | | | | | | | in order to do that, we need to ensure that the internal box is calculated, otherwise the position is still not updated correctly. This fixes wrong cursor positions in edi. fixes T8214 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10225
* elm_code_widget: initialize these vars correctlyMarcel Hollerbach2019-10-041-1/+1
| | | | | | | | otherwise we are setting a cursor from time to time at a uninitialized position. Which causes disappeared cursors Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10224
* Updating README for clang requirements.Bruno da Silva Belo2019-10-041-0/+1
| | | | | | | | OpenMP needs to be installed in system to sucessfully compile with clang, needs libomp, while gcc use his version, libgomp. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10213
* test_code: do not create a background by handMarcel Hollerbach2019-10-041-6/+2
| | | | | | | | the background here was wrong, it hasnt resizable hints, which means that the whole object cannot be resized. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10223
* elm_test: undef logging macros before redefining them in headerMike Blumenkrantz2019-10-041-0/+5
| | | | | | | | | | | | | | Summary: Depends on D10228 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10229
* evas: fix memory leak with Efl.Canvas.VgCedric Bail2019-10-042-10/+14
| | | | | | | | | | | | | | | | | | | | Summary: It is not correct to change the parent and hope that refcount will work for you. The parent chain is a decision made by the user, not something a widget can touch. Only ref count are to be used when given an outside object. As things where not triggering destruction, there was also no point where the image buffer would be getting to zero and be freed. This commit also fix this. Reviewers: Hermet, zmike Reviewed By: Hermet Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10169
* evas/object; fix null derefMike Blumenkrantz2019-10-041-2/+7
| | | | | | | | | | | | | | | | | | Summary: _efl_canvas_object_clipper_prev_reset() derefs obj->cur CID 1396985 Depends on D10211 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10212
* eio/dir: fix null derefMike Blumenkrantz2019-10-041-2/+3
| | | | | | | | | | | | | | | | | | Summary: above cases may fail, causing target to be null CID 1399103 Depends on D10210 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10211
* efl_ui/scroll_manager: fix null derefsMike Blumenkrantz2019-10-041-2/+2
| | | | | | | | | | | | | | | | Summary: CID 1405811, 1405804 Depends on D10208 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10209
* tests/eina: outdent codeMike Blumenkrantz2019-10-041-3/+3
| | | | | | | | | | | | | | | | | | Summary: this is a very important coverity issue. CID 1400838 Depends on D10205 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10206
* tests/strbuf: call va_end for varargsMike Blumenkrantz2019-10-041-0/+1
| | | | | | | | | | | | | | Summary: CID 1400792 Reviewers: brunobelo Reviewed By: brunobelo Subscribers: brunobelo, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10204
* epp: remove extra variable passed in format specifierMike Blumenkrantz2019-10-041-1/+1
| | | | | | | | | | | | | | Summary: CID 1402674 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10203
* ecore-x: protect against accidentally "un-managing" the root windowMike Blumenkrantz2019-10-041-0/+4
| | | | | | | | | | | | | | | | | | Summary: block calls to XSelectInput with the root window if the root window is currently being "managed" in-process in order to avoid breaking the running wm Depends on D10013 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10014
* ecore-x: add internal function for selecting just properties of root windowMike Blumenkrantz2019-10-042-0/+31
| | | | | | | | | | | | | | | | | Summary: this is just a shortcut for watching properties in the case where no wm is active in the process Depends on D10012 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10013
* ecore-x: track whether ecore-x is internally "managing" the root windowMike Blumenkrantz2019-10-041-6/+5
| | | | | | | | | | | | | | | | | | | | Summary: when ecore_x_window_manage is called, this is probably only for the case of managing the root window, i.e., running a window manager. store this state internally so that we can avoid calling additional XSelectInput later and fucking up the expected eventing Depends on D9899 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: devilhorns, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10012
* ecore-evas/x: detect and track wm existence, apply visibility correctlyMike Blumenkrantz2019-10-041-3/+19
| | | | | | | | | | | | | | | | | | | | | | | Summary: this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether a wm exists, and bypasses waiting for a configure event from a nonexistent wm if the screen is not currently managed fix T7838 Depends on D10014 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T7838 Differential Revision: https://phab.enlightenment.org/D9900
* ecore-x: fix null derefs in window prop codeMike Blumenkrantz2019-10-041-8/+14
| | | | | | | | | | | | | | | | | Summary: handle cases where null params could be passed and cause crashes @fix Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9899
* efl: improve error message to be really useful.Cedric Bail2019-10-041-1/+5
| | | | | | | | | | | | Reviewers: zmike, bu5hm4n Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10168
* efl_ui_selection_manager: fix potential out of bounce accessStefan Schmidt2019-10-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Summary: We have been casting the selection to unsigned char * for the address of sel and not for the value. Coverity pointed this out: Overrunning buffer pointed to by (unsigned char *)&sel of 8 bytes by passing it to a function which accesses it at byte offset 167 using argument 168 It seems this has been working by memory layout and luck if I understand it all correctly. Coverity ID: 1402666 Reviewers: thiepha, raster, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10107
* efl_ui_focus_managr_sub: fix a err messageMarcel Hollerbach2019-10-041-0/+12
| | | | | | | | | | with this commit there are a few errors less, for the case a object is destroyed while registered as a border element in the sub manager. This adds a few more callbacks to the list of callbacks, however, i could not messure a big performance impact. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10067
* ecore_thread: Fix arguments to match with the function call.Woochanlee2019-10-041-3/+4
| | | | | | | | | | | see the _eina_thread_internal() function r = c->func((void*) c->data, eina_thread_self()); The second param has been missed in ecore_thread_worker, ecore_direct_worker functions. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10073
* eina_log: ensure that we do not spam journald with our intree binariesMarcel Hollerbach2019-10-041-1/+1
| | | | | | | | | | | | | EFL_RUN_IN_TREE is set for all binaries that are executed during build time, and test suites. With this commit we are ensuring that we are not sending messages during that time to journald, otherwise we would waste a lot of time + we would create a lot of unneccessary log messages. (eina test suite runtime with journald hook: 11.21s without journald hook: 0.57s) Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10076
* ector engine: +null checking.Hermet Park2019-10-041-6/+9
| | | | | | | | Null pixels is allowed when drawing region is 0, In that case, the pixel buffer can be destroyed earlier by vg. @fix
* elm_test: mark image_zoomable test as non-legacyMike Blumenkrantz2019-10-041-1/+1
| | | | | | | | | | | | Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10053
* eina_log: do not fallback to INFO when we run with systemd supportMarcel Hollerbach2019-10-041-4/+0
| | | | | | | | | | INFO is a way too verbose log domain, this lead to the fact that we spammed journald before the first frame with ~200-300 messages (depending on the setup) which is quite a lot. Additionally, this also lead to the fact that we often TIMEOUT our own tests. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10075
* elementary_codegen: check before use to avoid use after freeStefan Schmidt2019-10-041-0/+4
| | | | | | | | | | | These might or might not have been freed already, depending on the breaks form the above loop. Before we are having a use after free here better check on it before free'ing another time. Coverity IDs: 1402671, 1402701 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10047
* efl_ui_selection_manager: free allocated memory after local useStefan Schmidt2019-10-041-0/+1
| | | | | | | | | | This temporary allocation is only used in this block and goes out of scope when leaving. Make sure we free the resource before this happens. Coverity ID: 1402653 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D10045
* efl_io_model: next try to fix this race conditionMarcel Hollerbach2019-10-049-1/+88
| | | | | | | | | | | | | | | | | | | what is happening is that a file gets announced through eio_model listing code, at this point of time, the monitor does not yet know about the file. If the file now gets deleted between the annoncing and the learning of the file from the monitor, then the file got an ADD event, but no DEL event. Which is a bug. With this commit there is a new API which asks the monitor if the file already has the knowledge about the files existance, or not. A few monitors like win32 inotify or cocoa do not have context about the file directly, if the OS is now having the same bug, then we are again in trouble, however, we canot do anything about that. In the case of kevent or poll, this asks the context of the monitor if the file is already there. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10006
* elm_test_widget_focus: cleanup callbacks correctlyMarcel Hollerbach2019-10-041-0/+2
| | | | | | | | | | | | | we need to delete the callback here, otherwise the objects are deleted later on, which: - changes focus, which leads to - callbacks executed with stacked addresses from a dead function this fixes a testsuite failure on the release build. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10020
* eo: custom created legacy events should be unfreezableMarcel Hollerbach2019-10-041-0/+1
| | | | | | | | | | | | | a while back we have moved event submission from custom lists to eo events. We also merged together the freeze and thaw functions, however, this brought up one bug. smart_callbacks and the likes (those that used custom lists before) are not effected by the legacy freeze and thaw functions. This means, we should declare these legacy wrapper objects unfreezable in order to obtain this behaviour. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com> Differential Revision: https://phab.enlightenment.org/D10016
* ecore/signal: increase maximum signal throughputMike Blumenkrantz2019-10-042-134/+158
| | | | | | | | | | | | | this adds 4 more signal handling fds and loops over them for reading/writing signal info in order to handle more signals when the buffer of one (or more) pipes is full also update the unit test to verify that we are receiving all the events without dropping any and bump the number of signals to 2000 since we should now be able to handle that many Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10027
* tests/ecore: add stress test for main loop signal handlingMike Blumenkrantz2019-10-041-0/+23
| | | | | | | this explodes after about 500 signals, so make it 1000 for a good test Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10026
* ecore/signal: also use nonblock for writing side of signal pipeMike Blumenkrantz2019-10-041-6/+12
| | | | | | | | | | | | | | if any efl-based process receives a bunch of signals in a short period of time, it will deadlock in the signal handler. this is unavoidable given the current signal handling architecture by setting nonblock, we can at least avoid deadlocking even if it means we'll be losing signal events @fix Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10025
* disable meson builds for this branchMike Blumenkrantz2019-09-181-20/+0
| | | | | | | | | there was a lot of work done on the meson build related to moving files around and adding features and such, and it's too difficult to reliably separate and backport all these changes meson was not the officially supported build system for 1.22, so there's no need to continue building this as it's approaching EOL anyway
* release: Update NEWS and bump version for 1.22.5 releasev1.22.5Mike Blumenkrantz2019-09-182-2/+15
|
* elm_config: fix to check if eet_open failsWonki Kim2019-09-181-0/+5
| | | | | | | | | | | | | | Summary: this patch adds a guard block in case of failure of eet_open(). Reviewers: bu5hm4n, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9987
* Revert "efl_io_model: remove custom counting logic"Marcel Hollerbach2019-09-181-0/+81
| | | | | | | | | | | | | | | | | Summary: This reverts commit d794a0d3d95c3addcb21df75606c444c6e3ed6d8. This breaks Efl_Io_Model. Reviewers: cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10003
* elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.setCedric Bail2019-09-181-1/+0
| | | | | | | | Model do not own the Eina_Value when it is set on them. They can make a copy of it, but shouldn't free it. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9945
* eina: prevent leak of Eina_Value internal allocation.Cedric Bail2019-09-181-2/+1
| | | | | | | | | | eina_value_copy assume the given Eina_Value as target is not initialized when it copy the source in it. In eina_value_reference_copy we were initialising before calling eina_value_copy which would then override and leak the internal pointer no fault of the users. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9943
* eina: turn on Eina_Mempool tests for OneBig too.Cedric Bail2019-09-181-0/+14
| | | | | Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9940
* eina: fix free support in eina OneBig mempool.Cedric Bail2019-09-181-1/+2
| | | | | | | | | We use an Eina_Trash to store freed pointer, which require the item size to be at least the size of a pointer. There wasn't any test suite enable for OneBig mempool and we never used free on a small item size... Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9939
* eina: fix eina_mempool_from to not report pointer that have never been ↵Cedric Bail2019-09-181-3/+12
| | | | | | | allocated as allocated. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9938
* efl_ui_image: implement missing APIMarcel Hollerbach2019-09-182-0/+35
| | | | | | | | | | | | | | the API calls have not been implemented, this revision implements these APIs as redirects to the image if those are a edje object. Normally this should be a calling the legacy edje API. However, this is here really hard as imitating the correct callback behaviour is hard. And the correct behaviour with the eina value type is also just leading to copying the implementation from edje. So in order to keep the amount of code low here, this just uses the efl-api to redirect the requests. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9989
* evas - in case handle scope data being nullCarsten Haitzler (Rasterman)2019-09-181-0/+1
| | | | | apbbb saw something that had this scope return null ... so handel - but it shouldn't get this far... can't figure out why though.
* efl_ui_focus_manager_calc: fix resource leaksMarcel Hollerbach2019-09-182-3/+5
| | | | this fixes CIDs 1396965 & 1396984
* elm/datepicker, timepicker: Fix uninitialized varsXavi Artigas2019-09-182-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Summary: Should fix all timepicker and datepicker uninitializer variable usage detected by Coverity: 1396954 Uninitialized scalar variable: efl_ui_timepicker.c 1396978 Uninitialized scalar variable: efl_ui_timepicker.c 1397006 Uninitialized scalar variable: efl_ui_timepicker.c 1396979 Uninitialized scalar variable: efl_ui_datepicker.c 1404748 Uninitialized scalar variable: efl_ui_datepicker.c 1404757 Uninitialized scalar variable: efl_ui_datepicker.c Test Plan: Everything builds and passes tests. Coverity should complain less. Reviewers: stefan_schmidt, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9967
* evas - rsvg loader - comment out deprecated func from rsvg we don't needCarsten Haitzler (Rasterman)2019-09-181-1/+2
| | | | | it seesm we don't need this. unref should shut down the rsvg obj anyway, and rsvg_handle_close() has been deprecated since 2.46
* tests/edje: handle file modifications properly on windowsMike Blumenkrantz2019-09-181-2/+22
| | | | | | | | | | | | | | Summary: we don't have access to utimensat and I'm too busy to figure out why Reviewers: vtorri, bu5hm4n, devilhorns Reviewed By: vtorri Subscribers: cedric, #reviewers, #committers Tags: #efl_build Differential Revision: https://phab.enlightenment.org/D9914
View Lorry Controller Status