diff options
author | woochan lee <wc0917.lee@samsung.com> | 2015-03-12 15:42:30 +0900 |
---|---|---|
committer | ChunEon Park <hermet@hermet.pe.kr> | 2015-03-12 15:42:30 +0900 |
commit | d98721a056f1408ff99d347a57154ae4d3599ab7 (patch) | |
tree | ac0be007cbc78d1cac6727b952c8449749ebec94 | |
parent | 260cdd6150d567fcee8d1afaf690e4b90cd16a2b (diff) | |
download | elementary-d98721a056f1408ff99d347a57154ae4d3599ab7.tar.gz |
genlist: Send param item type instead of eo item type.
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix
Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2136
-rw-r--r-- | src/lib/elm_genlist.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c index 87b3c2d4b..4aa0d8681 100644 --- a/src/lib/elm_genlist.c +++ b/src/lib/elm_genlist.c @@ -7560,9 +7560,12 @@ _elm_genlist_select_mode_set(Eo *obj EINA_UNUSED, Elm_Genlist_Data *sd, Elm_Obje (sd->select_mode == ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY)) { Eina_List *l, *ll; - Elm_Gen_Item *it; - EINA_LIST_FOREACH_SAFE(sd->selected, l, ll, it) + Elm_Object_Item *eo_it; + EINA_LIST_FOREACH_SAFE(sd->selected, l, ll, eo_it) + { + ELM_GENLIST_ITEM_DATA_GET(eo_it, it); _item_unselect(it); + } } } |