diff options
author | Amitesh Singh <amitesh.sh@samsung.com> | 2015-08-15 22:46:51 +0530 |
---|---|---|
committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2015-08-17 11:07:45 +0200 |
commit | 91db102d209437c68d4af336da0d0c3de7291dd7 (patch) | |
tree | 674ac17305172a34603b2ad3d5cdd135ea001e24 | |
parent | b70edf3e6995b2a1bb5db88b3d7df24725704dde (diff) | |
download | elementary-91db102d209437c68d4af336da0d0c3de7291dd7.tar.gz |
list: fix crash while setting nearest item in viewport
This is an example of classic code copy and paste mistake.
Probably inspired from similar code in genlist/gengrid.
We were actually deleting the other items (except selected one) in
viewport in _elm_list_nearest_visible_item_get() which results into crash
while deleting the list object.
@fix
Resolves: T2662
-rw-r--r-- | src/lib/elm_list.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/lib/elm_list.c b/src/lib/elm_list.c index 1cd1560ba..604d3d730 100644 --- a/src/lib/elm_list.c +++ b/src/lib/elm_list.c @@ -1233,7 +1233,6 @@ _elm_list_nearest_visible_item_get(Evas_Object *obj, Elm_List_Item_Data *it) if (ELM_RECTS_INCLUDE(vx, vy, vw, vh, cx, cy, cw, ch) && !elm_object_item_disabled_get(EO_OBJ(item))) { - eina_list_free(item_list); return item; } } @@ -1248,12 +1247,10 @@ _elm_list_nearest_visible_item_get(Evas_Object *obj, Elm_List_Item_Data *it) if (ELM_RECTS_INCLUDE(vx, vy, vw, vh, cx, cy, cw, ch) && !elm_object_item_disabled_get(EO_OBJ(item))) { - eina_list_free(item_list); return item; } } } - eina_list_free(item_list); return it; } |