| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
this exceptional code prevents the deletion of the item
in the middle of the callback.
|
|
|
|
| |
This reverts commit 94f0f1ba40d6066d4bf8b7594c2c636b49966b16.
|
|
|
|
|
|
|
|
|
| |
This reverts commit 0e7d521151ba93f3b5955caaf9b906e160ab6057.
Conflicts:
src/lib/elm_genlist.c
src/lib/elm_widget.h
|
|
|
|
| |
this clearing items are still valid.
|
|
|
|
|
| |
still, there were case item or genlist is cleared in the user callback.
don't access the cleared items if they are requested deletion.
|
|
|
|
|
|
| |
this should probably just happen in _item_select() to avoid future incidents
ref T1986
|
|
|
|
|
|
|
|
| |
This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8.
this broke the selection callback completely and makes every genlist app unusable.
please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
|
|
|
|
|
|
| |
if user deletes the item in the callback,
current function(_item_select) would be corrupted.
just leave the callback call in the last of the function.
|
|
|
|
|
| |
some logic of deleting item were duplicated.
this fixes fileselector crash issue.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: fixes make check failures on atspi tests.
Reviewers: cedric
Subscribers: seoz
Maniphest Tasks: T2001
Differential Revision: https://phab.enlightenment.org/D1870
|
|
|
|
| |
this missing would cause crash of the genlist when it's items are cleared.
|
|
|
|
|
|
|
| |
don't corrupt list pointer.
we can clear items more simply.
Thanks ya-kov for reporting.
|
| |
|
|
|
|
| |
Thanks, bug reported by thierry@substanciel.fr .
|
|
|
|
|
|
|
| |
this fixes d6f4040d0c62c220f2339d2a57126fde43e85e19 for the non-common
path that normalizes then applies new orientation
@fix
|
|
|
|
|
|
|
|
|
| |
Summary: This fixes Coverity CID1261370. strrchr can return NULL here,
so we need to check that 'p' is valid.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
Internal hacks should not affect user facing API. This commit adds a new
API to do the internal hack. This is still bad, but it's much less than
what was there before.
This fixes the main issue introduced by commit:
63a5cdf0f8516c16a62233da0c2af0e10a13264b
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During deletion of a window, widgets considered as droppable targets
have to remove their DnD callbacks. To achieve this, elm_drop_target_del
is called from the DEL callback (destructor). This function has to
determine if X11 or Wayland is used. Since the parent is already unknown
at this stage, only checking the engine name can give this
information.
On a regular window, the engine name is related to the target display.
The problem happens when an inline window is used. The engine is a
buffer and no information is given regarding the target display.
The patch fixes it by checking the nature of the Ecore Evas parents. It
supports nested windows (inline inside inline... inside XWin).
@fix
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
palette_box had stretched height exceeding its items size.
Now it will have proper height fitting to own items.
Reviewers: Hermet, Jaehyun, raster
Reviewed By: raster
Subscribers: raster, Hermet
Differential Revision: https://phab.enlightenment.org/D1840
|
|
|
|
|
| |
this fixes build of location_example_01.c as per fix in D1863 but done
properly so people can't use elm elocation unless they enable beta apis
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
When first page is last page, elm_scroller_last_page_get need to return 0.
But if pagesize is bigger then current content height or width, value will be returned -1.
So fix this cases to return 0.
Test Plan: If set elm_scroller_page_set bigger then current content size, then issue is occurred.
Reviewers: seoz, jaehwan, raster
Reviewed By: raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D1860
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
@fix
The elm image orient_set api looks like it is a state, and it is
documented to SET the orietnation, but the code actually DOEs that
orientation when you set it. so docs and api name didnt match
functionality at all. this was bad an an oversight. you didn't notice
until you set orientation multiple times to an image. this fixes the
implementation to be as documented - a state that is applied and
remains that way until set to something else. setting to the same
orientation has no efect as with color, size, etc. etc. in evas.
you could look on this as an api break, but then either the docs
change AND api name changes to match the code, or code changes to
match the docs. we don't keep bug compatibility in efl and in this
case i'm making the call to break the behavior of a function as it
was broken already with respect to name and docs.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This reverts commit 1879cc39258c63c24f0abcff56558b1f1b60167a.
Hermet, please check this commit it makes Fileselector crash,
looks like you inverted the values: 1 should be EINA_TRUE.
I recommend you to use Exactness to run all the tests automatically.
|
| |
|
|
|
|
| |
this broke decoration item text. reverted.
|
|
|
|
| |
emit signal to view item to do something additional.
|
|
|
|
| |
newly added in 2955ebc5dd01fbfb5a3286b724c8a40915864ad8
|
| |
|
| |
|
|
|
|
|
|
| |
this is a giant hack to provide widget parenting in e. do not use this function, do not use this type, do not even read the related documentation.
@feature
|
|
|
|
|
|
|
| |
clean up decorate_item_realize() function.
use macro and remove old debug code.
no actual logical change.
|
|
|
|
| |
removed unnecessary calls.
|
|
|
|
| |
we don't need these macros anymore since eo has introduced.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
On some systems (e.g. OS X), both Apple's windows manager and X11 can cohabit,
therefore we need to check for the DISPLAY environment variable only when ELM_DISPLAY
is not specified.
Reviewers: cedric, devilhorns, seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D1721
|
|
|
|
| |
ref T1930
|
| |
|
|
|
|
| |
no logic change.
|
| |
|
| |
|
|
|
|
|
| |
there were multiple ports for item procedures.
one port is enough.
|
|
|
|
|
|
|
|
| |
delete genlist item directly.
instead, remove the bunch of code that was related to lazy deletion.
we can success, if we clean up the resources and callback calls properly.
here i only found item focus callback that (may) required the lazy deletion.
|
|
|
|
|
|
|
| |
tarball
We need to list the icons here to let autotools know we want them int the release
tarballs.
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a non-useless manner"
This reverts commit fd71874024d14e5374aef93eae7d4cfbc0ea4521.
As the commit message says, the test crashes now. The ticket 1973 is
related to that issue.
Now, I understand there could be a bug inside inline stuff but it doesn't
mean that you have to push it and screw up all the test. You could just
attach a patch to the ticket and that's all folks!
|
| |
|