| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: Ifd69d54b3024b6234d919f78ea1939201856e471
|
| |
|
|
|
|
|
|
| |
Reviewers: tasn, felipealmeida, raster, cedric
Differential Revision: https://phab.enlightenment.org/D2750
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
If the transition scale flag is enable in edje,
this value affect the transition scale for edje.
@feature
Test Plan: test elementary_config with enventor tool
Reviewers: raster, Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2288
|
|
|
|
|
| |
- Add more descriptions in the test.
- Set the focus to the first button automatically.
|
| |
|
| |
|
|
|
|
|
| |
It is surprising that there is no such a comment on a scrollerable
interface considering the complexity of scroller.
|
| |
|
|
|
|
|
|
|
| |
_signal is used after free. _signal will be freed soon any way.
This was introduced in 3da3082.
This fixes coverity CID 1308263.
|
|
|
|
| |
This fixes coverity CID 1308264.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: This is a patch to fix T2453 where elm apps in weston/E did
not display the icon on the border. This is just preliminary support
because it only tries to find the efreet desktop file based on
_elm_appname. This support Could be extended to allow efreet to search
based on window title, etc, etc.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
This Patch is regarding D2553, but funtionally independent patch.
D2557 is also related with this patch, so to test working fine,
need to install those all three patches.
1. _elm_interface_scrollable_content_region_show store wx
into scroll_interface_data without coverting mirrored_x.
fix to store wx to mirror-converted x if is_mirrored.
2. _elm_scroll_x_mirrored_get return mirroed_x after compare zero not minx.
so current mirrored_x couldn't be less then 0.
fix to check min not 0 for set return value.
3. _elm_scroll_x_mirrored_get calculation need to consider start position of scroller.
some scroller(e.g. gengrid) start from non-zero position, so calculation need to change
like below.
ret = (cw - (x + w - min));
@fix
Test Plan: You can test this after merge D2553 patch and D2557 and test gengrid2.
Reviewers: raster, Hermet, seoz, jaehwan, tanwar.umesh07, cedric
Subscribers: tanwar.umesh07, Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2558
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: Issue: Gengrid item comes over group item on click.
Test Plan:
Run elementary test.
Open GenGrid Group. Click on any item which slightly overlap with group item.
Item comes over group item.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh
Differential Revision: https://phab.enlightenment.org/D2589
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
value in item_update
Summary:
elm_gengrid_item_update perform item_unrealize/item_realize/item_place itself.
But when gengrid items are added and not calculated yet,
caller want to get item's index after execute elm_gengrid_item_update,
return value is wrong because item_place update it's position in not-updated item's x and y.
to prevent this,
if item position is already updated,
do not updates position in item place.
additionally,
I fixed gengrid item prepend wrong posiiton update.
gengrid item position start from 1 not 0, so item_position_update also must be started from 1.
@fix
Test Plan:
To test this scenario,
need to fix src/bin/test_gengrid.c first.
1. add below codes in bottom of _after_bt_clicked(line 703).
```
Elm_Object_Item *it = elm_gengrid_item_next_get(id->item);
printf("before update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
elm_gengrid_item_update(it);
printf("after update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
```
2. execute elementary_test and go to gengrid2 test.
3. add 3 items and select 2nd item then add new item by insert after.
4. you can see index is changed wrong value after item_update executed.
after add fallback code in item_update,
index is returned same value even after item_update execusion.
Reviewers: raster, Hermet, seoz, jaehwan
Subscribers: anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2616
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Elementary widgets have different behavior of using the mouse, they need to be unified.
- swipe : without checking on hold, just checking drag state.
- longpress : after longpress, _item_unhighlight(), _item_unselect() are called.
- select : when the mouse pointer leaves item area, _item_unhighlight(), _item_unselect() are called.
First, apply this commit https://phab.enlightenment.org/D2550
Test Plan: elementary_test -> list
Reviewers: seoz, Hermet, CHAN, woohyun, kimcinoo, jaehwan, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2622
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
item_unselect check it->select status, so when item highlighted but not selected,
item highlight is remaining even after unselect_cb is called.
And item_select and item_highlight are separated, but item_unselect and item_unhighlight are mixed.
so divide them, too.
This patch will solve upon problem.
Reviewers: seoz, woohyun, Hermet, CHAN, raster, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2653
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
gengrid realize/unrealize items each smart calculation if their posiiton is updated.
This concept will be occurred useless view object creation and deletion.
So instead of delete items in unrealize function, push item cache into cache list,
and pop item cache from cache list in realize function to reuse item view object
more efficiently.
the cache concept is already implemented in genlist widget and this patch is improved
item cache of genlist cache.
@feature
```
NOTICE: This patch is written under the D2561 Patch which add elm_gengrid_item_fields_update.
So it must submitted after D2561.
```
Test Plan:
I've tested below three cases,
1. tested ith this patch in elementary_test and checked all gengrid features are working properly.
2. tested with changing CACHE_MAX to another value which is set 40 in default
and checked all gengrid features are working properly.
3. tested with set it->item->nocache true, and checked cache is never generated
and checked all gengrid features are working properly.
Reviewers: raster, Hermet, seoz, jaehwan, singh.amitesh
Subscribers: eagleeye, singh.amitesh, Jaehyun
Differential Revision: https://phab.enlightenment.org/D2641
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the speed of dragging
Summary:
Currently the values in spinner change while dragging only based on
the amount of pixels dragged, this patch will enable Spinner to change value
based on the speed of dragging so that it will be more user friendly. This
will help users to alter drag values by big amounts if dragged in a good speed.
Test Plan: test_spinner.c in elementary_test
Reviewers: raster, prince.dubey, shilpasingh, cedric
Reviewed By: cedric
Subscribers: poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2659
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
-
Revert "focus: Added internal widget APIs of focus highlight object of elm window."
This reverts commit 3f98d71830163a154762f2d16301d720c781b7c5.
- Revert "List: Focus highlight when loop is enable"
This reverts commit 57ad32a900e71f83441bf7246671b8f16a8ec909.
- Revert "genlist: Focus highlight when loop is enable"
This reverts commit 91282a22cba66ee5e7799018d3abe8957fb1b1fa.
Reviewers: seoz, raster, jpeg, SanghyeonLee
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D2725
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Show days of previous and next month on the blank area of calendar.
@feature
Test Plan: See calendar widget on elementary_test.
Reviewers: raster, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2728
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Looking at the base array of pixels,
the real middle of taken picture
is actually number 8 from array of 17 pixels (which starts from 0).
@fix
Reviewers: reutskiy.v.v, raster, NikaWhite, cedric
Reviewed By: NikaWhite, cedric
Differential Revision: https://phab.enlightenment.org/D2749
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: raster, Hermet, cedric
Reviewed By: cedric
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2767
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
SEG_FAULT happens when the object which has selection is deleted,
and new selection is done at another object.
Reason: loss_cb is not removed when the object which has selection is deleted.
When new selection is set for new object, the loss_cb is called for deleted
object. As result, SEG_FAULT happens.
Test Plan:
Run elementary test, open Entry, do selection,
close Entry window, open Entry one more time, do selection.
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2763
|
|
|
|
|
|
|
|
|
| |
When elm_config_all_flush is called, another processes should get
the config of current process instead of saved base.cfg.
so current process save the config to flush.cfg and another processes
read it when it is changed.
@fix
|
|
|
|
|
|
|
|
|
|
| |
Summary: Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: cedric, raster, seoz, Hermet
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2741
|
|
|
|
|
|
|
|
| |
Summary: Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: cedric, raster, seoz
Differential Revision: https://phab.enlightenment.org/D2744
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Added test case to enable/disable mouse wheel. Mouse Wheel is
used to scroll the genlist up/down.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan: elementary_test -> Genlist Focus -> Wheel Disabled
Reviewers: raster, Hermet, cedric
Subscribers: sachin.dev, singh.amitesh, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2757
|
|
|
|
|
|
|
| |
Code specific to X11 should not be part of elm_entry and can be easily
replaced with elm_cnp APIs.
@fix T2183
|
|
|
|
|
|
| |
- Reset loss cb after invocation as it is no more needed
- When selection is set, previous owner loss cb is invoked only
if the new owner and the previous one are different.
|
|
|
|
| |
@fix
|
|
|
|
|
|
|
| |
This type is not a standard type and can be handled as a text/uri-list
of one uri.
@fix
|
|
|
|
|
| |
The tag insertion has to be done only from elm_entry callback. elm_cnp
is not supposed to know what will be done with the data.
|
|
|
|
|
| |
When no \n is present at the end of the uris list, the function doesn't
return the uri.
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
The internal API "_elm_widget_item_highlight_in_theme()" look like for list item highlight.
but it can use in another widget which has item view as elm_layout.
In that case, ERR log will be printed.
Reviewers: singh.amitesh, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2736
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
When item_process is success, then we want to call _item_process_post.
Old code was confusing before.
Reviewers: raster, Hermet, SanghyeonLee
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2739
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: @fix
Reviewers: raster, seoz, SanghyeonLee
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2730
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
This API can be used by widgets like Genlist/Gengrid, which implements
Elm_Interface_Scrollable interface.Mouse wheel is used to scroll up and
down on widget.
@feature
Test Plan: elementary_test -> Scroller -> Wheel Disable
Reviewers: raster, Hermet, cedric, SanghyeonLee, singh.amitesh
Subscribers: JackDanielZ, herdsman, cedric, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2715
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in edc
Summary:
elm_colorselector get its padding size from data in edc.
However, when calculating the padding size, it does not consider
base_scale of the style from where it gets padding size.
In this commit, the padding size from edc is divided by its
base_scale so that desirable size can be calculated.
@fix
Reviewers: Hermet, woohyun
Subscribers: woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2721
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and focus when intersect.
Summary: Highlighted genlist item overlap with group item during scrolling and focus when itersect.
Test Plan:
Run elementary_test.
open Genlist Group.
select one item and try to cross the group item via scrolling.
Highlighted item comes over group item.
Reviewers: Hermet, raster, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh
Differential Revision: https://phab.enlightenment.org/D2640
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
item crosses item block size".
Summary: "In Tree effect feature, during expansion of tree, when total number of items crosses block count, items start floating".
Test Plan: Run elementary_test, open Genlist Tree, keep expanding items untill it crosses number of count 32 (Block count). Resize the window, floting items can be seen.
Reviewers: raster, cedric
Subscribers: shilpasingh, poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2627
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: modify to not allocate Eina_Rectangle and use it directly on the stack with EINA_RECTANGLE_SET
Reviewers: raster, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2737
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
This fixes following issue.
1. Add genlist items
2. Clear genlist by elm_genlist_clear()
3. Append items.
Genlist items are shrinked. This patch fixes that issue.
@fix
Partially resolves: T2367
Reviewers: Hermet, raster, cedric, raoulh, SanghyeonLee
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2733
|
| |
|
|
|
|
|
|
| |
- TARGETS notifier is specific to CnP and should not be called for DnD
- On DnD (when drag starts) and on CnP, it doesn't make sense that the TARGETS
type are sent to the potential target. Only basic types should be sent.
|
|
|
|
|
| |
follow on from b1c5de0b9aa67b9d5cc4722e9462830beb3af37b,
aa7f859da10ce007a7b945a8703e70161c96146d
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test Plan:
1. open "elementary_test colorselector"
2. click "all" button
Reviewers: cedric, seoz, Hermet, raster
Differential Revision: https://phab.enlightenment.org/D2635
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|