summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Blumenkrantz <zmike@osg.samsung.com>2016-03-10 11:21:11 -0500
committerMike Blumenkrantz <zmike@osg.samsung.com>2016-03-10 11:21:11 -0500
commit0b69c40d92636c5ded29ed22c8afae3e46965730 (patch)
treec5cae7b7fe65a45016d4f6e5601105c6f3909363
parent77602a58535b7df8c96f38d84437b5b3081f5977 (diff)
downloadenlightenment-0b69c40d92636c5ded29ed22c8afae3e46965730.tar.gz
resolve harmless coverity reports in wireless module
CIDs 1352825, 1352826, 1352827
-rw-r--r--src/modules/wireless/connman.c2
-rw-r--r--src/modules/wireless/wireless.c1
2 files changed, 2 insertions, 1 deletions
diff --git a/src/modules/wireless/connman.c b/src/modules/wireless/connman.c
index 662e23a8fd..c41a00d1d0 100644
--- a/src/modules/wireless/connman.c
+++ b/src/modules/wireless/connman.c
@@ -1110,7 +1110,7 @@ _connman_dbus_dict_append_array(Eldbus_Message_Iter *array, const char *key, Ein
variant = eldbus_message_iter_container_new(dict, 'v', "as");
array2 = eldbus_message_iter_container_new(variant, 'a', "s");
EINA_ARRAY_ITER_NEXT(val, i, str, it)
- eldbus_message_iter_basic_append(array2, 's', str ?: "");
+ eldbus_message_iter_basic_append(array2, 's', str);
eldbus_message_iter_container_close(variant, array2);
eldbus_message_iter_container_close(dict, variant);
eldbus_message_iter_container_close(array, dict);
diff --git a/src/modules/wireless/wireless.c b/src/modules/wireless/wireless.c
index 58ca034df1..d7f86b3692 100644
--- a/src/modules/wireless/wireless.c
+++ b/src/modules/wireless/wireless.c
@@ -380,6 +380,7 @@ _wireless_array_notequal(Eina_Array *a, Eina_Array *b)
unsigned int i;
if ((!!a) != (!!b)) return EINA_TRUE;
+ if ((!a) && (!b)) return EINA_FALSE;
if (eina_array_count(a) != eina_array_count(b)) return EINA_TRUE;
for (i = 0; i < eina_array_count(a); i++)
if (eina_array_data_get(a, i) != eina_array_data_get(b, i)) return EINA_TRUE;