summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeffrey Stedfast <fejj@ximian.com>2001-08-22 17:58:44 +0000
committerJeffrey Stedfast <fejj@src.gnome.org>2001-08-22 17:58:44 +0000
commit1a9e38879b94dd5a0061b332ecaf7b8218c5ea97 (patch)
tree29047213628871fde2983702aaa02fae769bc5b4
parent1f27ce43b6308896253fb9e88ae8ab3d716365d8 (diff)
downloadevolution-data-server-1a9e38879b94dd5a0061b332ecaf7b8218c5ea97.tar.gz
Oops. Fixed a mis-use of GPtrArray. If we set_size, then using
2001-08-22 Jeffrey Stedfast <fejj@ximian.com> * providers/pop3/camel-pop3-folder.c (pop3_generate_uids): Oops. Fixed a mis-use of GPtrArray. If we set_size, then using g_ptr_array_add will assume `size' elements have already been initialized and will start appending on to the end.
-rw-r--r--camel/ChangeLog7
-rw-r--r--camel/providers/pop3/camel-pop3-folder.c6
2 files changed, 11 insertions, 2 deletions
diff --git a/camel/ChangeLog b/camel/ChangeLog
index 5eaf86925..a0e6e0776 100644
--- a/camel/ChangeLog
+++ b/camel/ChangeLog
@@ -1,3 +1,10 @@
+2001-08-22 Jeffrey Stedfast <fejj@ximian.com>
+
+ * providers/pop3/camel-pop3-folder.c (pop3_generate_uids):
+ Oops. Fixed a mis-use of GPtrArray. If we set_size, then using
+ g_ptr_array_add will assume `size' elements have already been
+ initialized and will start appending on to the end.
+
2001-08-21 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-context.c (pgp_verify): Turn on --batch and reenable
diff --git a/camel/providers/pop3/camel-pop3-folder.c b/camel/providers/pop3/camel-pop3-folder.c
index f9f53c7e5..6a7a1e670 100644
--- a/camel/providers/pop3/camel-pop3-folder.c
+++ b/camel/providers/pop3/camel-pop3-folder.c
@@ -163,10 +163,12 @@ pop3_generate_uids (CamelFolder *folder, int count, CamelException *ex)
camel_object_unref (CAMEL_OBJECT (stream));
uid = base64_encode_simple (digest, 16);
- if (uid && *uid)
- g_ptr_array_add (uids, uid);
+ uids->pdata[i] = uid;
}
+ if (i < count)
+ g_ptr_array_set_size (uids, i);
+
return uids;
exception: