summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOlivier CrĂȘte <olivier.crete@collabora.com>2013-12-05 17:14:29 -0500
committerOlivier CrĂȘte <olivier.crete@collabora.com>2013-12-05 17:14:29 -0500
commitcbe9ad35878f921ea7ad67957335eb7a2685eb93 (patch)
tree2e471128fdf9b4d8db3f28cb98f8f3e4a86f4602
parentad52fadfa918a3f0f72dd400502e9b6e0813d218 (diff)
downloadfarstream-cbe9ad35878f921ea7ad67957335eb7a2685eb93.tar.gz
rtpsession: Need to read the method on stop too
Otherwise it used an initialized variable. Thank you clang-analyzer
-rw-r--r--gst/fsrtpconference/fs-rtp-session.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/gst/fsrtpconference/fs-rtp-session.c b/gst/fsrtpconference/fs-rtp-session.c
index d9821d7c..e20539fb 100644
--- a/gst/fsrtpconference/fs-rtp-session.c
+++ b/gst/fsrtpconference/fs-rtp-session.c
@@ -4961,13 +4961,12 @@ fs_rtp_session_handle_dtmf_event_message (FsRtpSession *self,
goto invalid;
gst_structure_get_boolean (es, "start", &e_start);
+ if (!gst_structure_get_int (ms, "method", &m_method))
+ goto invalid;
+ gst_structure_get_int (es, "method", &e_method);
+
if (m_start)
{
- if (!gst_structure_get_int (ms, "method", &m_method))
- goto invalid;
- gst_structure_get_int (es, "method", &e_method);
-
-
if (!gst_structure_get_int (ms, "number", &m_number))
goto invalid;
gst_structure_get_int (es, "number", &e_number);