summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-03-02 13:01:53 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2022-03-28 22:40:45 +0200
commit81e99640d5e7ba09576ce8cf40de180b946550d6 (patch)
tree82df03ee88669b98b2b487802837a0c1251075b7
parent97a21e9373f2b9ddd6f66adbcd2b31848ab8fab8 (diff)
downloadffmpeg-81e99640d5e7ba09576ce8cf40de180b946550d6.tar.gz
avformat/mov: Disallow empty sidx
It appears this is not allowed "Each Segment Index box documents how a (sub)segment is divided into one or more subsegments (which may themselves be further subdivided using Segment Index boxes)." Fixes: Null pointer dereference Fixes: Ticket9517 Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 4419433d77278cb742944c4514be5f72a04103c0) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/mov.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 94b2c079e3..e225dde84b 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -3698,7 +3698,7 @@ static int mov_read_sidx(MOVContext *c, AVIOContext *pb, MOVAtom atom)
index->track_id = track_id;
index->item_count = avio_rb16(pb);
- index->items = av_mallocz_array(index->item_count, sizeof(MOVFragmentIndexItem));
+ index->items = index->item_count ? av_mallocz_array(index->item_count, sizeof(MOVFragmentIndexItem)) : NULL;
if (!index->items) {
av_freep(&index);