summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-03-21 21:03:13 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2022-04-04 00:05:36 +0200
commit70522b7262c6dcce9deefb311a2a8127ce447203 (patch)
treefe2966bdb50e07647c1380d02c14151aeac4811f
parent1ed490b9dc5770df691dd741e57a9072afcc39c9 (diff)
downloadffmpeg-70522b7262c6dcce9deefb311a2a8127ce447203.tar.gz
avcodec/exr: Avoid signed overflow in displayWindow
The inputs are unused except for this computation so wraparound does not give an attacker any extra values as they are already fully controlled Fixes: signed integer overflow: 0 - -2147483648 cannot be represented in type 'int' Fixes: 45820/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5766159019933696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 1291568c9834c02413ab5d87762308f15b4ae9c6) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/exr.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/exr.c b/libavcodec/exr.c
index 0d5b3467d1..ded9d85000 100644
--- a/libavcodec/exr.c
+++ b/libavcodec/exr.c
@@ -1832,8 +1832,8 @@ static int decode_header(EXRContext *s, AVFrame *frame)
dx = bytestream2_get_le32(gb);
dy = bytestream2_get_le32(gb);
- s->w = dx - sx + 1;
- s->h = dy - sy + 1;
+ s->w = (unsigned)dx - sx + 1;
+ s->h = (unsigned)dy - sy + 1;
continue;
} else if ((var_size = check_header_variable(s, "lineOrder",