summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-09-18 14:28:03 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2022-11-03 23:29:48 +0100
commit51ccf7f5c6c5cb094c74526b21ce1e70d6e8d4ec (patch)
treea92d0ba25140f9022e5c5559cbe70e727050d8b5
parentcef1c6311d1f127fb61c19fd13689f1c2f40e428 (diff)
downloadffmpeg-51ccf7f5c6c5cb094c74526b21ce1e70d6e8d4ec.tar.gz
avformat/mxfdec: Check run_in is within 65536
Fixes: signed integer overflow: 9223372036854775807 - -2146905566 cannot be represented in type 'long' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6570996594769920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 7786097825d9e3f02b4574c1924c28818eb83340) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/mxfdec.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index f8c1df796b..b31ddb5b21 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -63,6 +63,7 @@
#include "mxf.h"
#define MXF_MAX_CHUNK_SIZE (32 << 20)
+#define RUN_IN_MAX (65535+1) // S377m-2004 section 5.5 and S377-1-2009 section 6.5, the +1 is to be slightly more tolerant
typedef enum {
Header,
@@ -3657,6 +3658,7 @@ static int mxf_read_header(AVFormatContext *s)
KLVPacket klv;
int64_t essence_offset = 0;
int ret;
+ int64_t run_in;
mxf->last_forward_tell = INT64_MAX;
@@ -3666,7 +3668,10 @@ static int mxf_read_header(AVFormatContext *s)
}
avio_seek(s->pb, -14, SEEK_CUR);
mxf->fc = s;
- mxf->run_in = avio_tell(s->pb);
+ run_in = avio_tell(s->pb);
+ if (run_in < 0 || run_in > RUN_IN_MAX)
+ return AVERROR_INVALIDDATA;
+ mxf->run_in = run_in;
mxf_read_random_index_pack(s);