summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-02-08 00:43:56 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2022-04-09 22:19:41 +0200
commit12e26cffcf965bf0b090aac5f9ab00ea4f71efbf (patch)
tree6e52400dbcc16f5c8b801dc1db6efcd243f02339
parenta8a8fda5cfeaa544a03050a5e2fc66fe9601604f (diff)
downloadffmpeg-12e26cffcf965bf0b090aac5f9ab00ea4f71efbf.tar.gz
avcodec/sonic: Use unsigned for predictor_k to avoid undefined behavior
Fixes: signed integer overflow: -1094995529 * 24 cannot be represented in type 'int' Fixes: 44436/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-4874459459223552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 28008bf95ed9b2ab5945ae6658358ad7c7f1df35) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/sonic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c
index 9498919d2f..d902beb501 100644
--- a/libavcodec/sonic.c
+++ b/libavcodec/sonic.c
@@ -1018,7 +1018,7 @@ static int sonic_decode_frame(AVCodecContext *avctx,
// dequantize
for (i = 0; i < s->num_taps; i++)
- s->predictor_k[i] *= s->tap_quant[i];
+ s->predictor_k[i] *= (unsigned) s->tap_quant[i];
if (s->lossless)
quant = 1;