summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-09-12 23:56:50 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-09-17 00:09:08 +0200
commit8bbd97109c993b50a00a88f2b773252ed1b83fc0 (patch)
tree263ffc8a99206ef84985cb9dd1092f9a32dcb41d
parent2a71cbeb019fabd70f04ca9d2ec5d0bff3b3e3d2 (diff)
downloadffmpeg-8bbd97109c993b50a00a88f2b773252ed1b83fc0.tar.gz
avcodec/ra144enc: Don't free unnecessarily
The init function of the real_144 encoder calls its own close function if a call to ff_lpc_init() fails; yet nothing has been allocated before that point and ff_lpc_init() can be expected to clean up after itself on error (the documentation does not say anything to the contrary and the current implementation can only fail if the only allocation fails, so there is nothing to clean up on error anyway), so this is unnecessary. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
-rw-r--r--libavcodec/ra144enc.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/libavcodec/ra144enc.c b/libavcodec/ra144enc.c
index 059f582334..c6965c5c47 100644
--- a/libavcodec/ra144enc.c
+++ b/libavcodec/ra144enc.c
@@ -65,14 +65,11 @@ static av_cold int ra144_encode_init(AVCodecContext * avctx)
ret = ff_lpc_init(&ractx->lpc_ctx, avctx->frame_size, LPC_ORDER,
FF_LPC_TYPE_LEVINSON);
if (ret < 0)
- goto error;
+ return ret;
ff_af_queue_init(avctx, &ractx->afq);
return 0;
-error:
- ra144_encode_close(avctx);
- return ret;
}