summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2013-04-10 15:02:01 +0200
committerAnton Khirnov <anton@khirnov.net>2013-04-30 12:00:55 +0200
commit8cd472d3f947a6233e7dc628f0dc71c74e62413a (patch)
tree773631b217b23469445ea644c859afb7e282fc0b
parenta83c0da539fb07260310bc3b34056239d2b138b2 (diff)
downloadffmpeg-8cd472d3f947a6233e7dc628f0dc71c74e62413a.tar.gz
avconv: make output -ss insert trim/atrim filters.
This makes output -ss sample-accurate for audio and will allow further simplication in the future.
-rw-r--r--Changelog3
-rw-r--r--avconv.c5
-rw-r--r--avconv_filter.c12
3 files changed, 11 insertions, 9 deletions
diff --git a/Changelog b/Changelog
index ca5dbac352..76af6ac1a3 100644
--- a/Changelog
+++ b/Changelog
@@ -14,7 +14,8 @@ version 10:
- JPEG 2000 decoder
- new asetpts filter (same as setpts, but for audio)
- new trim and atrim filters
-- avconv -t option is now sample-accurate when transcoding audio
+- avconv -t and -ss (output-only) options are now sample-accurate when
+ transcoding audio
version 9:
diff --git a/avconv.c b/avconv.c
index 3b50f20cbb..3b4d2f674d 100644
--- a/avconv.c
+++ b/avconv.c
@@ -681,11 +681,6 @@ static int poll_filter(OutputStream *ost)
av_rescale_q(of->start_time,
AV_TIME_BASE_Q,
ost->st->codec->time_base);
-
- if (of->start_time && filtered_frame->pts < 0) {
- av_frame_unref(filtered_frame);
- return 0;
- }
}
switch (ost->filter->filter->inputs[0]->type) {
diff --git a/avconv_filter.c b/avconv_filter.c
index 0a47c95191..1d8044d70b 100644
--- a/avconv_filter.c
+++ b/avconv_filter.c
@@ -183,7 +183,7 @@ static int insert_trim(OutputStream *ost, AVFilterContext **last_filter, int *pa
char filter_name[128];
int ret = 0;
- if (of->recording_time == INT64_MAX)
+ if (of->recording_time == INT64_MAX && !of->start_time)
return 0;
trim = avfilter_get_by_name(name);
@@ -199,8 +199,14 @@ static int insert_trim(OutputStream *ost, AVFilterContext **last_filter, int *pa
if (!ctx)
return AVERROR(ENOMEM);
- ret = av_opt_set_double(ctx, "duration", (double)of->recording_time / 1e6,
- AV_OPT_SEARCH_CHILDREN);
+ if (of->recording_time != INT64_MAX) {
+ ret = av_opt_set_double(ctx, "duration", (double)of->recording_time / 1e6,
+ AV_OPT_SEARCH_CHILDREN);
+ }
+ if (ret >= 0 && of->start_time) {
+ ret = av_opt_set_double(ctx, "start", (double)of->start_time / 1e6,
+ AV_OPT_SEARCH_CHILDREN);
+ }
if (ret < 0) {
av_log(ctx, AV_LOG_ERROR, "Error configuring the %s filter", name);
return ret;