summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-09-17 23:15:56 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2022-10-09 22:15:49 +0200
commit80ec0ca973587ff8f72141d4bbb09a12aca91b90 (patch)
tree78526fd6aecffd63cd9a82d81713941f27ebee05
parentd52ed1be9e073e082c960b703a1129dfb7cf4b22 (diff)
downloadffmpeg-80ec0ca973587ff8f72141d4bbb09a12aca91b90.tar.gz
avformat/icodec: Check nb_pal
Fixes: signed integer overflow: 538976288 * 4 cannot be represented in type 'int' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-6690068904935424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Peter Ross <pross@xvid.org> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit db73ae0dc114aa6fae08e69f977944f056a24995) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/icodec.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/libavformat/icodec.c b/libavformat/icodec.c
index d86b85099d..23cd91412d 100644
--- a/libavformat/icodec.c
+++ b/libavformat/icodec.c
@@ -204,6 +204,9 @@ static int read_packet(AVFormatContext *s, AVPacket *pkt)
AV_WL32(buf + 32, image->nb_pal);
}
+ if (image->nb_pal > INT_MAX / 4 - 14 - 40)
+ return AVERROR_INVALIDDATA;
+
AV_WL32(buf - 4, 14 + 40 + image->nb_pal * 4);
AV_WL32(buf + 8, AV_RL32(buf + 8) / 2);
}