summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2023-01-08 20:03:40 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2023-04-21 01:55:11 +0200
commit5cc68bb176e8450990e465b86d5a4e02700bef02 (patch)
tree72a4035dcdb5174b896cf9e9a04799af0ca15cbd
parent255794f03494f17de94edeb1eefb3e602be9b0ba (diff)
downloadffmpeg-5cc68bb176e8450990e465b86d5a4e02700bef02.tar.gz
avcodec/scpr: Test bx before use
Fixes: out of array access on 32bit Fixes: 54850/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5302669294305280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 1b59de3770b2e3f7f44ec4adba27c88b79adaaec) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/scpr.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c
index dc890a87e5..9d04494b36 100644
--- a/libavcodec/scpr.c
+++ b/libavcodec/scpr.c
@@ -459,6 +459,9 @@ static int decompress_p(AVCodecContext *avctx,
int run, bx = x * 16 + sx1, by = y * 16 + sy1;
uint32_t r, g, b, clr, ptype = 0;
+ if (bx >= avctx->width)
+ return AVERROR_INVALIDDATA;
+
for (; by < y * 16 + sy2 && by < avctx->height;) {
ret = decode_value(s, s->op_model[ptype], 6, 1000, &ptype);
if (ret < 0)