summaryrefslogtreecommitdiff
path: root/libavformat/subtitles.c
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2021-10-01 15:54:48 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2021-10-02 17:16:29 +0200
commit8766361fc16b6d25ee8be880bf55c9761490cb99 (patch)
treed4f79fd4a736f7aa0d653aa9a96009578d4d2748 /libavformat/subtitles.c
parent2004d8d36dd5f85ae806ea00f7cd78a2c65d3815 (diff)
downloadffmpeg-8766361fc16b6d25ee8be880bf55c9761490cb99.tar.gz
avformat/subtitles: Honour ff_subtitles_read_line() documentation
It claims to always zero-terminate its buffer like snprintf(), yet it does it not on EOF. Because of this the mcc demuxer used uninitialized values when reading an empty input file. Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavformat/subtitles.c')
-rw-r--r--libavformat/subtitles.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/libavformat/subtitles.c b/libavformat/subtitles.c
index c6701c6a60..3ba5e2b217 100644
--- a/libavformat/subtitles.c
+++ b/libavformat/subtitles.c
@@ -437,6 +437,7 @@ ptrdiff_t ff_subtitles_read_line(FFTextReader *tr, char *buf, size_t size)
size_t cur = 0;
if (!size)
return 0;
+ buf[0] = '\0';
while (cur + 1 < size) {
unsigned char c = ff_text_r8(tr);
if (!c)